Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get_idn fails for AMI430 3D instrument #4590

Closed
jenshnielsen opened this issue Sep 8, 2022 · 1 comment · Fixed by #4610
Closed

Get_idn fails for AMI430 3D instrument #4590

jenshnielsen opened this issue Sep 8, 2022 · 1 comment · Fixed by #4610
Labels
driver

Comments

@jenshnielsen
Copy link
Collaborator

the Instrument class implements get_idn by calling ask but that will in general not work on virtual instruments such as the AMI4303D but raise an exception that is handled and logged.

Virtual instruments should either override get_idn to not fail and respond with something useful or we should rework this so get_idn is not implemented like this for the generic class
This was referenced Sep 13, 2022
Merged
Open
@astafan8
Copy link
Contributor

opened #4611 for the generic issue about all virtual instruments

@bors bors bot closed this as completed in a36b07f Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
driver
Projects
None yet
Milestone
No milestone
2 participants
@jenshnielsen @astafan8