Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Chart Settings -> Tools -> Show Vega spec -> Open Vega Editor does nothing in vscode #153

Open
RandomFractals opened this issue Dec 15, 2019 · 9 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@RandomFractals
Copy link

RandomFractals commented Dec 15, 2019

Expected:

Clicking on Open Vega Editor popup would open generated chart Vega specification in an online Vega Editor in the default browser using vscode.open command with encoded vega spec url. See #152 for more info on the latter part.

Alternatively, you can integrate with Vega Viewer 📈 vscode extension for this part and open generated Vega specification in Vega Viewer via commands.executeCommand('vega.preview', vegaSpecUri)

@danmarshall
Copy link
Contributor

duplicate of #75

@RandomFractals
Copy link
Author

it might be a duplicate, but are you going to address it & integrate it with Vega Viewer I mentioned when you resolve it? ...

@RandomFractals
Copy link
Author

RandomFractals commented Dec 23, 2019

besides, your #75 ticket has no description at all :)

@danmarshall
Copy link
Contributor

Hi Taras, sorry about abruptly closing this 😳. I'm curious of the interaction if someone does not have the Vega-Viewer extension installed...

@danmarshall danmarshall reopened this Dec 24, 2019
@RandomFractals
Copy link
Author

RandomFractals commented Dec 25, 2019

In that case it could just open Vega spec. json in default vscode JSON editor.

Since most Vega specs use json schema that would allow devs to review and edit that spec with IntelliSense at least.

You can check if Vega Viewer is installed and just default to: commands.executeCommand('vscode.open', vegaSpecUri)

See how I do it for Data Preview ext. in Vega Viewer to load loca data files:

RandomFractals/vscode-vega-viewer#52

@RandomFractals
Copy link
Author

RandomFractals commented Dec 25, 2019

so ... long story short ... I think you have a few good options I layed out there.

Let me know if you need a hand with it :)

I would like to see us integrate this Vega cobweb for the best vscode devs & Vega viz UX eventually ...

@RandomFractals
Copy link
Author

RandomFractals commented Dec 25, 2019

also, @casperOne & @arvind please provide your objections to the proposed & expected behaviour in text ... & your 👎 lol! since currently SandDance just doesn't do anything for that link click in vscode :)

@RandomFractals
Copy link
Author

RandomFractals commented Dec 25, 2019

@domoritz what's your pref. for this fix? ...

@danmarshall danmarshall added good first issue Good for newcomers help wanted Extra attention is needed labels May 21, 2020
@RandomFractals
Copy link
Author

@danmarshall any update on this? been sitting in your queue for months :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants