Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create, Clean-up/deduplicate AG-related XML rowsets in the RowsetImportEngine\TextRowset.xml #157

Closed
PiJoCoder opened this issue Apr 16, 2022 · 2 comments
Assignees
Labels
bug wave 1 - complete consider this issue for next wave of fixes

Comments

@PiJoCoder
Copy link
Collaborator

These rowsets are not really defined with columns. But also for tbl_availability_groups there is already a rowset defined

  • There is one defined for this, so delete this:
    <Rowset name="tbl_availability_groups" enabled="true" identifier="--sys.availability_groups--" type="RowsetImportEngine.TextRowset">
    </Rowset>
  • Define this one if needed and make sure there is data collected for it in PSSDIAG/SQL LogScout
    <Rowset name="tbl_dm_hadr_availability_replica_states" enabled="true" identifier="--sys.dm_hadr_availability_replica_states--" type="RowsetImportEngine.TextRowset">
    </Rowset>

- There is another one defined for it, so delete this: 
<Rowset name="tbl_availability_replicas" enabled="true" identifier="--sys.availability_replicas--" type="RowsetImportEngine.TextRowset">
</Rowset>

See related on the data collection side: microsoft/DiagManager#162

@PiJoCoder PiJoCoder added bug wave 1 - complete consider this issue for next wave of fixes labels Apr 21, 2022
@PiJoCoder
Copy link
Collaborator Author

Fixed in:
00119a6
f315c00

@PiJoCoder PiJoCoder removed the wave 1 - complete consider this issue for next wave of fixes label Aug 24, 2022
@PiJoCoder PiJoCoder added the wave 1 - complete consider this issue for next wave of fixes label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug wave 1 - complete consider this issue for next wave of fixes
Projects
None yet
Development

No branches or pull requests

3 participants