Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS 2019: Error adding nuget package to core project #2862

Closed
sibille opened this issue Jan 21, 2019 · 3 comments
Closed

VS 2019: Error adding nuget package to core project #2862

sibille opened this issue Jan 21, 2019 · 3 comments
Assignees
@sibille
Labels
bug The issue relates to the wizard not working or a problem with the generated code. Can Close Out Soon Work relating to this issue has been completed. VS Preview Issue The issue only exists when using the preview version of Visual Studio.
Milestone
3.1

Comments

@sibille
Copy link
Collaborator

sibille commented Jan 21, 2019

Adding SettingsStorage Feature does not add nuget Newtonsoft.Json to core project in VS 2019.

Error message: Method not found: 'Microsoft.VisualStudio.ProjectSystem.IProjectServices Microsoft.VisualStudio.ProjectSystem.IProjectService.get_Services()'.
@sibille sibille added VS Preview Issue The issue only exists when using the preview version of Visual Studio. bug The issue relates to the wizard not working or a problem with the generated code. labels Jan 22, 2019
@crutkas
Copy link
Member

crutkas commented Jan 22, 2019

I'm assuming in both scenarios we are using https://www.nuget.org/packages/Microsoft.VisualStudio.ProjectSystem/

they have a preview version, does that fix it?

@crutkas
Copy link
Member

crutkas commented Jan 22, 2019

looks like there is a breaking change per our call, https://github.com/Microsoft/VSProjectSystem/blob/b513b6eb3f73cb4233d6da0dff1f9fa527a73f68/doc/overview/breaking_changes_visual_studio_2019.md

@sibille sibille mentioned this issue Feb 19, 2019
Merged
@sibille sibille added this to the 3.1 milestone Feb 19, 2019
@sibille sibille added the Can Close Out Soon Work relating to this issue has been completed. label Feb 19, 2019
@sibille sibille self-assigned this Feb 27, 2019
@sibille
Copy link
Collaborator Author

sibille commented Mar 6, 2019

Verified in dev-nightly:
Templates version: 0.20.19065.1
Wizard version: 0.20.19065.1

@sibille sibille closed this as completed Mar 6, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sibille sibille

Labels
bug The issue relates to the wizard not working or a problem with the generated code. Can Close Out Soon Work relating to this issue has been completed. VS Preview Issue The issue only exists when using the preview version of Visual Studio.
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
2 participants
@crutkas @sibille