Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docCommentTemplate Does Not work with Assignments #14134

Closed
mjbvz opened this issue Feb 16, 2017 · 0 comments
Closed

docCommentTemplate Does Not work with Assignments #14134

mjbvz opened this issue Feb 16, 2017 · 0 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 16, 2017

TypeScript Version: 2.2.1-insiders-20170216

 
module.exports.myExport = function(a, b, c) {} 

Send a request for docCommentTemplate to the TSServer for line: 1, position: 1

Expected
A result should be returned like we would get for function(a, b, c) {} on its own

Actual
No result returned.

[Trace - 2:19:40 PM] Sending request: docCommentTemplate (103). Response expected: yes. Current queue length: 0
Arguments: {
    "file": "/Users/matb/projects/test/c.ts",
    "line": 1,
    "offset": 1
}
[Trace - 2:19:40 PM] Response received: docCommentTemplate (103). Request took 2 ms. Success: false . Message: No content available.

A few other patterns to support:

| TRIGGER HERE
module.exports = function() {...}
const myNamespace  = {}

| TRIGGER HERE
myNamespace.myExport = function() {...}

module.exports = myNamespace
@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Feb 16, 2017
@mhegazy mhegazy added the Bug A bug in TypeScript label Aug 29, 2017
@mhegazy mhegazy assigned ghost Aug 29, 2017
@ghost ghost closed this as completed in #18193 Sep 7, 2017
@ghost ghost added the Fixed A PR has been merged for this issue label Sep 7, 2017
@mhegazy mhegazy added this to the TypeScript 2.6 milestone Sep 7, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

No branches or pull requests

2 participants