Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make node type predicates public #15811

Closed
ghost opened this issue May 13, 2017 · 1 comment
Closed

Make node type predicates public #15811

ghost opened this issue May 13, 2017 · 1 comment
Labels
API Relates to the public API for TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 2.4

Comments

@ghost
Copy link

ghost commented May 13, 2017

There are a bunch of useful functions in utilities.ts that just test against a node kind, such as isImportClause. Currently these are all @internal. Could these be made public?
This would help slim down tsutils, which duplicates much of this behavior. Predicates like isDeclaration would be especially hard to maintain duplicates of.
@andy-hanson andy-hanson mentioned this issue May 13, 2017
Merged
4 tasks
@mhegazy
Copy link
Contributor

mhegazy commented May 13, 2017

Go for it.

@mhegazy mhegazy added the API Relates to the public API for TypeScript label May 13, 2017
@ghost ghost mentioned this issue May 27, 2017
Merged
@ghost ghost closed this as completed in #16121 May 31, 2017
@ghost ghost added the Fixed A PR has been merged for this issue label May 31, 2017
@mhegazy mhegazy added this to the TypeScript 2.4 milestone May 31, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
API Relates to the public API for TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 2.4
Development

No branches or pull requests
1 participant
@mhegazy