How should we handle directory renames with 'getEditsForFileRename'?

[mjbvz]

For a project:

jsconfig.json
index.ts
sub/
    a.ts
    b.ts

Where index.ts:

import {a} from './sub/a'
import {b} from './sub/b'
console.log(a, b);

If the user renames the directory sub -> sub2, how should we handle updating the paths using the getEditsForFileRename api? Is this something we want to support in V1?

I'm concerned that renaming directories may require a call to getEditsForFileRename for each file, which will be chatty

[ghost]

The code doesn't support this currently, so this is something we'll have to add. I think we're wrapping up ts2.9 today so no time to add it to that.

[mjbvz]

Ok, should the API be updated so that we can support this in the future? Or do you think the existing API will work?

[ghost]

I think we can just use the current function and detect that the path passed in is a directory.

[mjbvz]

Good with me. Just one question: what would the file be in that case? Just any file ts in the current project?

[ghost]

Right. The 'file' argument doesn't even show up in the LanguageService method.

[mhegazy]

@andy-ms let's try to get this in the next servicing release 2.9.2