Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related error spans for multiple default exports #25032

Closed
DanielRosenwasser opened this issue Jun 18, 2018 · 2 comments
Closed

Related error spans for multiple default exports #25032

DanielRosenwasser opened this issue Jun 18, 2018 · 2 comments
Labels
Bug A bug in TypeScript Domain: Related Error Spans Specifying regions for error messages/diagnostics on multiple locations. Help Wanted You can do this
Milestone

Comments

@DanielRosenwasser
Copy link
Member

Now that we support multiple related spans for errors (#10489, #22789, #24548), we'd like to improve an existing error message.

Currently, we provide an error on each declaration when a module has multiple export defaults.

A module cannot have multiple default exports

We can instead add a related span on all declarations but the first.

This export conflicts with the first. 

This can help users quickly glance at the original declaration.

@DanielRosenwasser DanielRosenwasser added the Domain: Related Error Spans Specifying regions for error messages/diagnostics on multiple locations. label Jun 18, 2018
@mhegazy mhegazy added the Bug A bug in TypeScript label Jun 19, 2018
@mhegazy mhegazy added this to the TypeScript 3.0 milestone Jun 19, 2018
@Kingwl
Copy link
Contributor

Kingwl commented Jul 2, 2018

i'd like to (try) work on this

@mhegazy
Copy link
Contributor

mhegazy commented Jul 2, 2018

go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: Related Error Spans Specifying regions for error messages/diagnostics on multiple locations. Help Wanted You can do this
Projects
None yet
Development

No branches or pull requests

5 participants