Automatic typings install does not trigger project refresh

[mjbvz]

From microsoft/vscode#59436

TypeScript Version: 3.2.0-dev.20181009

Search Terms:

• ATA, automatic typings acquisition

Code
Tested on macos with npm 6.4.1.

1. Clear the typings cache.
2. For a new JS project with contents:

package.json

{
    "dependencies": {
        "express": "4.16.3"
    }
}

main.js

import * as express from "express"
 
let a = express()

1. Open the project in vscode

2. Run npm install

3. Open main.js

4. Notice the ... suggestion on the import stating could not find a declaration file for module 'express'

5. Check ATA directory and see that express typings have been installed

Bug
The ... suggestion is never removed and we fail to get proper typings for express. After reloading the javascript project we do start seeing the correct suggestions

[sheetalkamat]

@DanielRosenwasser , @RyanCavanaugh Currently there is discrepancy between the way error is generated and typing requests queueing. ATA happens only if module is not resolved (to js or ts file) but error is generated if the resolution is not ts or json file. Which behavior is correct?