Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending Map with wrong number of type arguments shows no error #27951

Closed
ghost opened this issue Oct 17, 2018 · 1 comment · May be fixed by #56713
Closed

Extending Map with wrong number of type arguments shows no error #27951

ghost opened this issue Oct 17, 2018 · 1 comment · May be fixed by #56713
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue Fixed A PR has been merged for this issue

Comments

@ghost
Copy link

ghost commented Oct 17, 2018

TypeScript Version: 3.2.0-dev.20181017

Code

class MyMap extends Map<string> {}

Expected behavior:

Error: No base constructor has the specified number of type arguments.

Actual behavior:

No error.

Issue was introduced by #25374. The issues it fixed, #23551 and #25362, seem to work fine even if I revert the change. CC @sandersn to confirm that JS class augmentation has been fixed and #25374 can be reverted.

@ghost ghost added the Bug A bug in TypeScript label Oct 17, 2018
@sandersn
Copy link
Member

I change I made recently made sure that base type nodes lookup accounts for jsdoc everywhere, instead of a few places. That's probably what fixed the original issues. Reverting the lib changes seems like the right thing.

I can't find the PR right now, though.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue Fixed A PR has been merged for this issue
Projects
None yet
2 participants