Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a related span for subsequent variables/properties with different types #31520

Closed
DanielRosenwasser opened this issue May 21, 2019 · 0 comments · Fixed by #31521
Closed

Add a related span for subsequent variables/properties with different types #31520

DanielRosenwasser opened this issue May 21, 2019 · 0 comments · Fixed by #31521
Assignees
@DanielRosenwasser
Labels
Domain: Error Messages The issue relates to error messaging Domain: Related Error Spans Specifying regions for error messages/diagnostics on multiple locations. Experience Enhancement Noncontroversial enhancements
Milestone
TypeScript 3.5.1

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 21, 2019 •
edited

We currently error that separate variable declarations don't agree in their type. We can give a related span to the original declaration instead.

Sub-item of #22789.
@DanielRosenwasser DanielRosenwasser added Domain: Error Messages The issue relates to error messaging Domain: Related Error Spans Specifying regions for error messages/diagnostics on multiple locations. Experience Enhancement Noncontroversial enhancements labels May 21, 2019
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 3.6.0 milestone May 21, 2019
@DanielRosenwasser DanielRosenwasser self-assigned this May 21, 2019
@DanielRosenwasser DanielRosenwasser mentioned this issue May 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielRosenwasser DanielRosenwasser

Labels
Domain: Error Messages The issue relates to error messaging Domain: Related Error Spans Specifying regions for error messages/diagnostics on multiple locations. Experience Enhancement Noncontroversial enhancements
Projects
None yet
Milestone
TypeScript 3.5.1
Development

Successfully merging a pull request may close this issue.

Related error spans on disagreeing declarations microsoft/TypeScript
1 participant
@DanielRosenwasser