Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language service OOM on lodash DT tests when batch compilation succeeds #32111

Open
andrewbranch opened this issue Jun 26, 2019 · 0 comments
Open
Labels
Bug A bug in TypeScript Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output
Milestone

Comments

@andrewbranch
Copy link
Member

Various CI runs on lodash for DefinitelyTyped confirm that batch compilation works fine, but certain language service operations OOM consistently, and the PR doesn’t look particularly costly. This makes me wonder if the language service is doing more work than necessary.

DefinitelyTyped/DefinitelyTyped#36288

Benchmarking logs tell us exactly where the OOM happened, so we should be able to repro in VS Code by checking out refs/pull/36288/merge and requesting quick info and/or completions at one of the problem locations: https://dev.azure.com/definitelytyped/DefinitelyTyped/_build/results?buildId=6947

@andrewbranch andrewbranch added the Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output label Jun 26, 2019
@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Jul 30, 2019
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output
Projects
None yet
Development

No branches or pull requests

2 participants