From debian : please support multiple system dir

[bastien-roucaries]

Under debian and other distrib we want to load systemdir from a search path.

for instance we want first to look up from lib/x86_64-linux-gnu/nodejs then share/nodejs then lib/nodejs'

I tried a local patch but I do not suceed.

Could you help us ?

rouca@debian.org

[bastien-roucaries]

Patches incomplete from my side :

Index: node-typescript/lib/tsc.js
===================================================================
--- node-typescript.orig/lib/tsc.js
+++ node-typescript/lib/tsc.js
@@ -75146,14 +75146,20 @@ var ts;
                 }
             }
             if (rootNames.length && !skipDefaultLib) {
-                var defaultLibraryFileName = getDefaultLibraryFileName();
+               var defaultLibraryFileName = getDefaultLibraryFileName();
+               var relativePaths = process.config.variables.node_relative_path;
+               var relativePathsSplitted = relativePaths.split(':');
                 if (!options.lib && defaultLibraryFileName) {
-                    processRootFile(defaultLibraryFileName, true, false);
+                   ts.forEach(relativePathsSplitted, function(systempath) {
+                       processRootFile(systempath, true, false);
+                   });
                 }
                 else {
-                    ts.forEach(options.lib, function (libFileName) {
-                        processRootFile(ts.combinePaths(defaultLibraryPath, libFileName), true, false);
-                    });
+                   ts.forEach(relativePathsSplitted,function(systempath) {
+                       ts.forEach(options.lib, function (libFileName) {
+                            processRootFile(ts.combinePaths(systempath, libFileName), true, false);
+                       });
+                   });
                 }
             }
             missingFilePaths = ts.arrayFrom(ts.mapDefinedIterator(filesByName.entries(), function (_a) {

[bastien-roucaries]

The best for us will be the possibility to override hard coded system path by using a environement variable with path separated with : like TYPESCRIPT_PATH="/usr/share/nodejs/@types:/usr/lib/nodejs/@types:/usr/local/share/nodejs/@types"

[pravi]

I think if tsc searches in NODE_PATH or default paths set in nodejs instead of just node_modules for finding types, that will be the best option.

[pravi]

node -e "console.log(process.config.variables.node_relative_path);"
lib/x86_64-linux-gnu/nodejs:share/nodejs:lib/nodejs

So nodejs in debian looks in these paths for finding modules (configured with https://salsa.debian.org/js-team/nodejs/blob/master/debian/patches/dfhs_module_path_arch_triplet.patch), but tyepescript does not check in these paths when looking for type definitions.

[pravi]

tsc does not recognize NODE_PATH environment variable as well.

[SnarkBoojum]

Well, the proposal is that tsc should have a list of directories where it would look for modules and/or definitions. The package providing tsc would then be lightly patched in order to add Debian's system directories to that list. That would avoid stupid patches to tsconfig.json like this one in many packages.

[guimard]

Hi, any news here ?

[weswigham]

There's a typeRoots compiler option that probably does what you want.

[guimard]

Hi @weswigham, no it is not. Typescript does not follow node.js resolution policy, even when moduleResolution is set to node. So tsc isn't able to find a globally installed module