Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS binding should create real aliases for module.exports #37000

Closed
sandersn opened this issue Feb 25, 2020 · 0 comments · Fixed by #39770
Closed

JS binding should create real aliases for module.exports #37000

sandersn opened this issue Feb 25, 2020 · 0 comments · Fixed by #39770
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Milestone
Backlog

Comments

@sandersn
Copy link
Member

In JS, binding often puts symbols on things that should actually be aliases. Then there is ad-hoc alias-following code in the binder and checker that should really be consolidated with the real alias-handling code.
@sandersn sandersn added the Bug A bug in TypeScript label Feb 25, 2020
@sandersn sandersn added this to the Backlog milestone Feb 25, 2020
@sandersn sandersn mentioned this issue Feb 25, 2020
Merged
@sandersn sandersn mentioned this issue Jul 27, 2020
Merged
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Alias for commonjs require in JS microsoft/TypeScript
2 participants
@sandersn @typescript-bot