Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand when isNewIdentifierLocation is set in the syntax server #39033

Open
DanielRosenwasser opened this issue Jun 12, 2020 · 0 comments
Open
Labels
In Discussion Not yet reached consensus Suggestion An idea for TypeScript

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Jun 12, 2020

In #37713, we might not have a full picture of the world, so it might overly restrictive to only suggest identifiers in the current file. We should consider being more permissive so that editors don't aggressively auto-complete on identifiers in these contexts.


Aside: if we do this, we should make sure that the work done in #38836 doesn't cause conflicts.

For example, let's say you have an empty file like

thing/**/

and completions get triggered at /**/. A user should not get completions for thing at that point.

@DanielRosenwasser DanielRosenwasser changed the title Expand isNewIdentifierLocation to be true in statement/expression contexts in the syntax server Expand when isNewIdentifierLocation is set in the syntax server Jun 12, 2020
@DanielRosenwasser DanielRosenwasser added Suggestion An idea for TypeScript In Discussion Not yet reached consensus labels Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Discussion Not yet reached consensus Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

1 participant