Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't provide suggestions for certain global packages #44499

Open
DanielRosenwasser opened this issue Jun 8, 2021 · 0 comments
Open

Don't provide suggestions for certain global packages #44499

DanielRosenwasser opened this issue Jun 8, 2021 · 0 comments
Labels
Domain: Completion Lists The issue relates to showing completion lists in an editor Needs Proposal This issue needs a plan that clarifies the finer details of how it could be implemented. Suggestion An idea for TypeScript

Comments

@DanielRosenwasser
Copy link
Member

If you have @types/node installed, you shouldn't get a completion item for node when typing import "n.

It's unclear what the right thing to do here is. I don't think you always want to filter out non-module packages because a package might just be written in a weird way where you import it and all it does is introduce globals. At the very least, we could do some quick-and-dirty filtering.

@DanielRosenwasser DanielRosenwasser added Suggestion An idea for TypeScript Needs Proposal This issue needs a plan that clarifies the finer details of how it could be implemented. Domain: Completion Lists The issue relates to showing completion lists in an editor Domain: ES Modules The issue relates to import/export style module behavior and removed Domain: ES Modules The issue relates to import/export style module behavior labels Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: Completion Lists The issue relates to showing completion lists in an editor Needs Proposal This issue needs a plan that clarifies the finer details of how it could be implemented. Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

1 participant