JSON parse works with type Buffer

[KristianRykkje]

lib Update Request

Configuration Check

My compilation target is ES2015 and my lib is the default.

Missing / Incorrect Definition

parse(text: string, reviver?: (this: any, key: string, value: any) => any): any;

Sample Code

const object = JSON.parse(readFileSync("sample.json"));

Documentation Link

https://262.ecma-international.org/5.1/#sec-15.12.2
https://github.com/nodejs/node/blob/c41c09375b217d9daec614edb590147b14ff9b21/lib/buffer.js#L405

Suggestion

parse(text: string | Buffer, reviver?: (this: any, key: string, value: any) => any): any;

[IllusionMH]

Same as #17203 and moreover Buffer is Node specific type and doesn't looks like it belongs to standard lib files.

[RyanCavanaugh]

This is just an implicit coercion, not anything JSON.parse does.

[qwelias]

This is just an implicit coercion, not anything JSON.parse does.

Literally false, see the spec step 1: Let jsonString be ? ToString(text) which explicitly converts text arg to it's string representation before doing anything else

[RyanCavanaugh]

I'm curious what you think an implicit coercion is?