Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion Backlog Slog, 8/30/2021 #45648

Closed
andrewbranch opened this issue Aug 30, 2021 · 0 comments
Closed

Suggestion Backlog Slog, 8/30/2021 #45648

andrewbranch opened this issue Aug 30, 2021 · 0 comments
Assignees
Labels
Design Notes Notes from our design meetings

Comments

@andrewbranch
Copy link
Member

  • Feature Request: allow exclusion of node_modules when skipLibCheck is false #30511
    • shouldn't you just make your hand-authored .d.ts files .ts files?
      • Yes, probably. We currently have a fairly coherent posture that .d.ts files are not inputs—they don't get copied to outDir of a compilation. We probably wouldn’t change the .d.ts checking behavior without more broadly rethinking this position.
    • Action: leave issue open, remove from project board, update status on issue
  • Use generic defaults for "empty" constructors of Array, Map, Set #29786
    • reason was to not be allowed to write Map<string>
      • wait, is that really that bad? Looks unexpected if you're not familiar with the type definition or coming from another language and assume Map keys are always stringy.
      • could we have two overloads, one with two mandatory type params?
        • no, because we couldn't get the default <any, any>, you get unknown
    • would this matter if we were ever allowed to have strict libs with unknown?
      • that might help a little
    • we traded one problem for another, maybe let's not undo it again
    • sometimes when you do subtype reduction you want to get rid of the any if there's something more informed to use
    • Action: close issue/PR, not worth the flip flopping with potential breaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Notes Notes from our design meetings
Projects
None yet
Development

No branches or pull requests

1 participant