renaming node_modules directory with "javascript.updateImportsOnFileMove.enabled" option set to "always" causes crash

[ncpa0cpl]

TS Template added by @mjbvz

TypeScript Version: 4.5.2

Search Terms

• updateImports
• npm
• node_modules

---

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.62.0
• OS Version: Manjaro Linux

Steps to Reproduce:

1. set javascript.updateImportsOnFileMove.enabled to always
2. install and import multiple dependencies
3. change the directory name of the "node_modules" to anything else

When doing so VSCode attempts to update imports of many of the files inside the node_modules and if you have too many dependencies the amount of files it attempts to update is too high and causes the program to stop responding.

The worst part is that simply killing the application and starting it again doesn't necessarily fix the problem, in my case all of the updated files have opened in the editor as unsaved and persisted between closing and opening the application causing it to crash every time I opened it.

Perhaps the auto import update should never happen for any files in the node_modules, regardless of the user settings?

[mjbvz]

Yes I think we should never try to update imports under node_modules (although someone on the TS team will have to confirm that there aren't weird edge cases around this)