Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nesting user-defined type guards within a return object #47195

Open
5 tasks done
HenryMorgan-cd2 opened this issue Dec 19, 2021 · 1 comment
Open
5 tasks done

Allow nesting user-defined type guards within a return object #47195

HenryMorgan-cd2 opened this issue Dec 19, 2021 · 1 comment
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Suggestion An idea for TypeScript

Comments

@HenryMorgan-cd2
Copy link

Suggestion

πŸ” Search Terms

nested user-defined type guards

βœ… Viability Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

Currently, type guards can only return a boolean value (x is SomeType). I think it would be beneficial to allow this assertion to be nested within a more complex return type.

Playground link

πŸ“ƒ Motivating Example

function validate(data: IData): { error?: string, isValid: data is ValidData } {
    if (!data.name) {
        return { error: "Name is required", isValid: false }
    } else {
        return { isValid: true }
    }
}

πŸ’» Use Cases

Currently, we have to either have to assert properties when we use them (data.name!) or we manually type-cast the object within the check:

if (isValid) {
  const validData = someData as IValidData
}
@MartinJohns
Copy link
Contributor

Related: #46650

@RyanCavanaugh RyanCavanaugh added Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Suggestion An idea for TypeScript labels Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

3 participants