Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing HTMLMediaElement.preservesPitch #48444

Closed
Tenpi opened this issue Mar 26, 2022 · 4 comments
Closed

Missing HTMLMediaElement.preservesPitch #48444

Tenpi opened this issue Mar 26, 2022 · 4 comments
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Milestone

Comments

@Tenpi
Copy link

Tenpi commented Mar 26, 2022

lib Update Request

Configuration Check

My compilation target is ES2015 and my lib is the default.

Missing / Incorrect Definition

HTMLMediaElement.preservesPitch is missing from the types. It is supported in nearly every browser.

Sample Code

// throws error
videoElement.preservesPitch = true

Documentation Link

Documentation: https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/preservesPitch

@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Help Wanted You can do this Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript labels Mar 28, 2022
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Mar 28, 2022
@huytd
Copy link
Contributor

huytd commented Mar 30, 2022

Hi, I'd like to work on this issue

@huytd
Copy link
Contributor

huytd commented Mar 30, 2022

Based on the discussion in microsoft/TypeScript-DOM-lib-generator#1300, I think there is no need to fix this issue from within TypeScript's codebase.

The main reason for this issue is because preservesPitch is only available in the standard form in Chrome, and is prefixed in other browsers. Once the other browsers implemented it, the lib.dom.d.ts generator will be able to generate the type correctly.

Here are the relevant issues to track in Safari and Firefox:

@Tenpi
Copy link
Author

Tenpi commented Mar 30, 2022

Hi, thanks for the info, didn't know that it only works with a prefix on Firefox and Safari.

@jakebailey
Copy link
Member

This was fixed in #49596.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants