Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert in organizeImports in babel/babel #50866

Closed
amcasey opened this issue Sep 20, 2022 · 2 comments · Fixed by #50874
Closed

Assert in organizeImports in babel/babel #50866

amcasey opened this issue Sep 20, 2022 · 2 comments · Fixed by #50874
Assignees
Labels
Bug A bug in TypeScript Crawler-Detected Detected by a crawler running random TSServer operations on public code. Fix Available A PR has been opened for this issue

Comments

@amcasey
Copy link
Member

amcasey commented Sep 20, 2022

babel/babel - the assert is that this declare is missing __pos and __end.

Originally posted by @amcasey in #50835 (comment)

@amcasey
Copy link
Member Author

amcasey commented Sep 20, 2022

babel/babel

⚠️ Note that typescript-4.8.3 also had errors ⚠️
Req #292 - organizeImports
    at getPos (/typescript-4.8.3/lib/tsserver.js:150536:22)
    at assignPositionsToNode (/typescript-4.8.3/lib/tsserver.js:151494:44)
    at visitArrayWorker (/typescript-4.8.3/lib/tsserver.js:90473:48)
    at Object.visitNodes (/typescript-4.8.3/lib/tsserver.js:90436:23)
    at assignPositionsToNodeArray (/typescript-4.8.3/lib/tsserver.js:151499:30)
    at Object.visitEachChild (/typescript-4.8.3/lib/tsserver.js:90985:62)
    at assignPositionsToNode (/typescript-4.8.3/lib/tsserver.js:151491:30)
    at getNonformattedText (/typescript-4.8.3/lib/tsserver.js:151472:56)
    at getFormattedTextOfNode (/typescript-4.8.3/lib/tsserver.js:151443:26)
    at format (/typescript-4.8.3/lib/tsserver.js:151430:52)
    at /typescript-4.8.3/lib/tsserver.js:151432:78
    at computeNewText (/typescript-4.8.3/lib/tsserver.js:151432:36)
    at /typescript-4.8.3/lib/tsserver.js:151397:39
    at Object.mapDefined (/typescript-4.8.3/lib/tsserver.js:622:30)
    at /typescript-4.8.3/lib/tsserver.js:151395:42
    at Object.mapDefined (/typescript-4.8.3/lib/tsserver.js:622:30)
    at Object.getTextChangesFromChanges (/typescript-4.8.3/lib/tsserver.js:151381:27)
    at ChangeTracker.getChanges (/typescript-4.8.3/lib/tsserver.js:151320:45)
    at Object.organizeImports (/typescript-4.8.3/lib/tsserver.js:143322:34)
    at Object.organizeImports (/typescript-4.8.3/lib/tsserver.js:167640:39)
    at IOSession.Session.organizeImports (/typescript-4.8.3/lib/tsserver.js:179805:60)
    at Session.handlers.ts.Map.ts.getEntries._a.<computed> (/typescript-4.8.3/lib/tsserver.js:178260:61)
    at /typescript-4.8.3/lib/tsserver.js:180166:96
    at IOSession.Session.executeWithRequestId (/typescript-4.8.3/lib/tsserver.js:180157:28)
    at IOSession.Session.executeCommand (/typescript-4.8.3/lib/tsserver.js:180166:41)
    at IOSession.Session.onMessage (/typescript-4.8.3/lib/tsserver.js:180194:35)
    at Interface.<anonymous> (/typescript-4.8.3/lib/tsserver.js:184330:31)
Req #292 - organizeImports
    at getPos (/typescript-4.9.0-dev.20220918/lib/tsserver.js:151596:22)
    at assignPositionsToNode (/typescript-4.9.0-dev.20220918/lib/tsserver.js:152554:44)
    at visitArrayWorker (/typescript-4.9.0-dev.20220918/lib/tsserver.js:91123:48)
    at Object.visitNodes (/typescript-4.9.0-dev.20220918/lib/tsserver.js:91087:23)
    at assignPositionsToNodeArray (/typescript-4.9.0-dev.20220918/lib/tsserver.js:152559:30)
    at visitEachChildOfExportDeclaration (/typescript-4.9.0-dev.20220918/lib/tsserver.js:91627:66)
    at Object.visitEachChild (/typescript-4.9.0-dev.20220918/lib/tsserver.js:91267:42)
    at assignPositionsToNode (/typescript-4.9.0-dev.20220918/lib/tsserver.js:152551:30)
    at getNonformattedText (/typescript-4.9.0-dev.20220918/lib/tsserver.js:152532:56)
    at getFormattedTextOfNode (/typescript-4.9.0-dev.20220918/lib/tsserver.js:152503:26)
    at format (/typescript-4.9.0-dev.20220918/lib/tsserver.js:152490:52)
    at /typescript-4.9.0-dev.20220918/lib/tsserver.js:152492:78
    at computeNewText (/typescript-4.9.0-dev.20220918/lib/tsserver.js:152492:36)
    at /typescript-4.9.0-dev.20220918/lib/tsserver.js:152457:39
    at Object.mapDefined (/typescript-4.9.0-dev.20220918/lib/tsserver.js:621:30)
    at /typescript-4.9.0-dev.20220918/lib/tsserver.js:152455:42
    at Object.mapDefined (/typescript-4.9.0-dev.20220918/lib/tsserver.js:621:30)
    at Object.getTextChangesFromChanges (/typescript-4.9.0-dev.20220918/lib/tsserver.js:152441:27)
    at ChangeTracker.getChanges (/typescript-4.9.0-dev.20220918/lib/tsserver.js:152380:45)
    at Object.organizeImports (/typescript-4.9.0-dev.20220918/lib/tsserver.js:144344:34)
    at Object.organizeImports (/typescript-4.9.0-dev.20220918/lib/tsserver.js:168760:39)
    at IOSession.Session.organizeImports (/typescript-4.9.0-dev.20220918/lib/tsserver.js:180925:60)
    at Session.handlers.ts.Map.ts.getEntries._a.<computed> (/typescript-4.9.0-dev.20220918/lib/tsserver.js:179380:61)
    at /typescript-4.9.0-dev.20220918/lib/tsserver.js:181286:96
    at IOSession.Session.executeWithRequestId (/typescript-4.9.0-dev.20220918/lib/tsserver.js:181277:28)
    at IOSession.Session.executeCommand (/typescript-4.9.0-dev.20220918/lib/tsserver.js:181286:41)
    at IOSession.Session.onMessage (/typescript-4.9.0-dev.20220918/lib/tsserver.js:181314:35)
    at Interface.<anonymous> (/typescript-4.9.0-dev.20220918/lib/tsserver.js:185436:31)

Last few requests

{"seq":289,"type":"request","command":"organizeImports","arguments":{"scope":{"type":"file","args":{"file":"@PROJECT_ROOT@/packages/babel-generator/test/fixtures/edgecase/unary-op/input.js"}},"skipDestructiveCodeActions":false}}
{"seq":290,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":["@PROJECT_ROOT@/packages/babel-generator/test/fixtures/compact/while/output.js"],"openFiles":[]}}
{"seq":291,"type":"request","command":"updateOpen","arguments":{"changedFiles":[],"closedFiles":[],"openFiles":[{"file":"@PROJECT_ROOT@/packages/babel-generator/test/fixtures/flow/declare-exports/output.js","projectRootPath":"@PROJECT_ROOT@"}]}}
{"seq":292,"type":"request","command":"organizeImports","arguments":{"scope":{"type":"file","args":{"file":"@PROJECT_ROOT@/packages/babel-generator/test/fixtures/flow/declare-exports/output.js"}},"skipDestructiveCodeActions":true}}

Repro Steps

  1. git clone https://github.com/babel/babel
  2. In dir babel, run git reset --hard aad7eb743d1354a5475f9d43226bfedc5f149e4b
  3. Download RepoResults1/babel.babel.replay.txt from the artifact folder
  4. npm install --no-save @typescript/server-replay
  5. npx tsreplay ./babel ./babel.babel.replay.txt path/to/tsserver.js

@DanielRosenwasser DanielRosenwasser added Crawler-Detected Detected by a crawler running random TSServer operations on public code. Bug A bug in TypeScript labels Sep 21, 2022
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.9.1 milestone Sep 21, 2022
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Sep 21, 2022
@DanielRosenwasser
Copy link
Member

Thanks @a-tarasyuk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Crawler-Detected Detected by a crawler running random TSServer operations on public code. Fix Available A PR has been opened for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants