TypeScript Server Error (5.2.2) on update to 1.82.0 #55673
Comments
|
The extensions in the stack trace are definitely a red flag to me; we often see proxying extensions like these fail to pass through all parameters and break after an internal API change in TS. I think that’s more than likely what’s happening, but let me know if you can reproduce with those extensions disabled. |
andrewbranch
added
the
External
|
I don't know if it's the same exact cause, but I'm also having trouble with VSCode after upgrading to TypeScript 5.2.2 (from 4.9.5) (I'm using "workspace version" rather than VSCode version, but my workspace version now happens to also be 5.2.2) with error messages that are exactly the same, even though the stack trace isn't. In 4.9.5, I didn't have any issues, but now, I intermittently and seemingly randomly start getting errors like this in the "Extension Host" log: and once this happens, I have to run the VSCode command EDIT: Oh, just for completeness, here's my VSCode data, too: EDIT 2: I also just noticed version 1.82.1 was released, so I'll update to that one and see if the problem still remains. |
|
@alexschrod that is definitely a totally different code path, but if you can repro it reliably, we’ll take a repro (preferred) or TS Server logs! |
|
@alexschrod I encountered the same mistake. @andrewbranch I've been able to consistently reproduce this problem in all of my repo using typescript@5.2.2(workspace versioin) |
|
Can you provide a repo and instructions on how to reproduce? |
|
I've also run into this issue with typescript 5.2.2 (The second callstack in this issue posted by @alexschrod). I spent some time debugging the ts server locally, and this is what I've gathered so far, in case it's useful:
|
I found my problem due to TypeScript-Plugin-CSS-MODULES. I no longer use it anymore |
|
The plugins shouldnt be using |
|
@sheetalkamat there doesn't seem to be a |
|
|
|
That does seem to work, and I can see how it's better than using |
|
Hm, I didn’t realize that. @sheetalkamat? |
|
Sorry. Got this wrong the first time. its This makes sure that language service gets updated through project and the states are matched. |
|
Hi all, we've just had a report that Was there anything in the 5.2 release that changed regarding plugins? For reference, we're using:
(Source: https://github.com/mrmckeb/typescript-plugin-css-modules/blob/main/src/index.ts) |
|
@mrmckeb having the tsserver logs with repro would help with debugging. |
|
Unfortunately I've been unable to reproduce the issue (although the only information I have is that removing the plugin resolved the issue). I tested by creating a new Next.js app (with TypeScript 5.2.2), installing/configuring the plugin, and writing code in that app. @alexschrod and @Daydreamer-riri, you've both reported that you had issues here:
|
Hi, @mrmckeb, My application is in a monorepo managed by pnpm, and the plugin is v5.0.1 |
|
Hi @Daydreamer-riri, I'm also using pnpm and still wasn't able to reproduce after moving to a monorepo.
|
|
Sorry, I forgot to take the screenshot. |
|
I have seen this happen with TS I don't know how unique my situation is, but I can repro the issue every time by the following:
Here's a full log from a session where I reproduced the error by doing the above: at about shortly after we get a bunch of spam like this: then we get this which eventually finishes but then another reload happens (not sure why there are 2 of these kinds of events? the after that second reload, we get this series of events that leads to the error: |
|
I don't appear to hit this crash on TS Logs for that are here: https://gist.githubusercontent.com/ekilah/2a3385653c2101a268d320a87bb83c95/raw/32941e2856a048b60170c3acdb2cc984416e39f5/tsserver-deal-web-5.1.3.log This is about the spot in the log file where I added whitespace to my |
|
As this issue seems very rare (I know users on 5.2.2 that aren't hitting this issue), I'm hoping someone from the TS team can make some suggestions of what might be happening here? Details:
|
|
I tried 5.2.2 version and by trying to compile I got an error. Maybe it could help. typescript v5.3.0-dev.20231024 - no errors |
|
I have the same problem:
|
Not sure if this can be reproduced yet. Just updated VSCode which includes TypeScript 5.2.2 and this error occurred. Will modify/update this report with proper process and logs if I can get more info. Given the extensions reported in this error, it's not apparent to me yet if this is a VSCode issue or an extensions issue, but "something" in the new update just broke "something", and I'm starting here with the diagnostics. Will also advise extension authors.
Version: 1.82.0 (system setup)
Commit: 8b617bd08fd9e3fc94d14adb8d358b56e3f72314
Date: 2023-09-06T22:07:07.438Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.19045
Current scenario: I just opened an existing workspace with a TypeScript / React project. Linting was reporting that lodash is not installed, but it is, and I believe this error displayed during a rebuild.
I will reload the environment to see if this reproduces, and will test with and without the extensions shown in the error to see if either one of them triggers the issue.
The text was updated successfully, but these errors were encountered: