-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code actions "Move to file" and "Move to new file" are shown everywhere #56416
Comments
I wouldn't declare this as a generic light bulb issue, yet. Having refactoring sold by it does makes sense but it shouldn't be as spammy as it is today with 'Move...'. It seem they show unconditionally (like for loop counters or semicolons) and would benefit from some self-control, e.g only show when on a method, function, class etc ppp |
@jrieken atm, it is just shown in every non-empty line in a method, class, function, etc. and in some files, that means the entire file and nearly every line. Could maybe play around with only having it to show up at the line of function/class/methoid declaration, but not in the code body? Not sure if @mjbvz has any opinions on this. |
Some ideas:
|
馃挴 on that - showing the code action further down is noise and lowers my trust in light bulb being helpful (and not ad-space) |
HI @sandersn, I would like to have a go at this PR. Could I have a pointer to place in the code where the change should be, or discuss this issue with one of your team members in a meeting? We are currently looking into displaying code actions in the light-bulb menu in VS Code on empty lines too, and currently we are seeing the |
@aiday-mar I believe @navya9singh and @andrewbranch have worked the most on Move To File. |
data
The text was updated successfully, but these errors were encountered: