Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.88.0 update broke JS Auto Import functionality #58113

Closed
ChrisKimZHT opened this issue Apr 6, 2024 · 15 comments
Closed

1.88.0 update broke JS Auto Import functionality #58113

ChrisKimZHT opened this issue Apr 6, 2024 · 15 comments
Labels
Duplicate An existing issue was already created

Comments

@ChrisKimZHT
Copy link

Does this issue occur when all extensions are disabled?: Yes (Only enable Language Pack)

  • VS Code Version: 1.88.0
  • OS Version: Windows_NT x64 10.0.22631

Steps to Reproduce:

  1. Create a react project using create-react-app: create-react-app test
  2. Install antd UI Framework Package: npm install antd
  3. Open App.js in VSCode
  4. Input <But and wait for the autocomplete box pop up

1.87.2 Behavior: Auto Import working properly

1 87 2

1.88.0 Behavior: Auto Import not working

1 88 0

Detailed Version:

版本: 1.87.2 (user setup)
提交: 863d2581ecda6849923a2118d93a088b0745d9d6
日期: 2024-03-08T15:20:17.278Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Windows_NT x64 10.0.22631
版本: 1.88.0 (user setup)
提交: 5c3e652f63e798a5ac2f31ffd0d863669328dc4c
日期: 2024-04-03T13:26:18.741Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Windows_NT x64 10.0.22631
@alidmb

This comment has been minimized.

@jzwang-dev
Copy link

Two temp solutions:

  1. rename App.js to App.ts
    or
  2. downgrade typescript version to 5.3.x (you need to install typescript locally)

run npm install --save-dev typescript@5.3.3

image
image

@grentank
Copy link

grentank commented Apr 7, 2024

I have the latest version of VSCode and I have the same issue. Auto-imports do not work with neither MUI, nor React-bootstrap. Also I experience issues importing from react-router-dom (however after I manually import at least something from the library, auto-imports and import suggestions begin to work for the react-router-dom)

@slavoroi
Copy link

slavoroi commented Apr 8, 2024

Same here... Auto imports in a monorepo stopped working correctly.

@mjbvz mjbvz transferred this issue from microsoft/vscode Apr 8, 2024
@mjbvz mjbvz removed their assignment Apr 8, 2024
@jakebailey
Copy link
Member

jakebailey commented Apr 8, 2024

This is #57740 which was fixed by #57778 but was not backported to 5.4 (probably just missed).

You should be able to use the nightly TS extension to work around this for now.

@techUdayMungalpara
Copy link

I have the latest version of VSCode and I also face the same issue. Auto-imports does not work with any package only work with react .

@DysektAI
Copy link

DysektAI commented Apr 10, 2024

This is why MUI and possibly other packages are not working for auto import suggestions in .JS / .JSX on VS Code 1.88+

Options to fix this, at the moment:
1.) Use the extension on any version

2.) Use VS Code v1.87.2 until its fixed

@red2678
Copy link

red2678 commented Apr 11, 2024

I have similar issues here. It does not really find any of my internal components in a large React project. Also, if it does find one and I click, it will just insert the import right where my cursor was.

....How can a critical feature like this get broken? Wow.

@DysektAI
Copy link

I have similar issues here. It does not really find any of my internal components in a large React project. Also, if it does find one and I click, it will just insert the import right where my cursor was.

....How can a critical feature like this get broken? Wow.

Welcome to opensource I hope you dont depend on ESLint... Its in... A state jumped from ~8.5.3 directly to 9.0.0 and broke so much... I feel like I have been playing bug chaser and dependency simulator for the past week almost now with all these major issues

@starball5
Copy link

Related on Stack Overflow: Auto-import suggestions not coming up in VS Code 1.88.0

@jakebailey
Copy link
Member

This issue was fixed in 5.4.5; we're just waiting for it to be picked up by VS Code. If you're having trouble, update TS in your local project and configure VS Code to use that, or install the nightly extension (which would generally speaking be very helpful for feedback).

@jakebailey
Copy link
Member

1.88.1 is out and should fix this.

@ChrisKimZHT
Copy link
Author

March 2024 Recovery 1 (1.88.1) solved

@hellohejinyu
Copy link

image

Always Initialzing JS/TS language features。TypeScript 5.4.5 + VSCode 1.88.1

@jakebailey
Copy link
Member

Please file a new issue. This thread is not a catch-all for every bug that seems to happen in 1.88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests