Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons are completely messed up in Visual Studio member list #58384

Open
Peter-Juhasz opened this issue May 1, 2024 · 4 comments
Open

Icons are completely messed up in Visual Studio member list #58384

Peter-Juhasz opened this issue May 1, 2024 · 4 comments
Assignees
Labels
Needs Investigation This issue needs a team member to investigate its status.

Comments

@Peter-Juhasz
Copy link

πŸ”Ž Search Terms

icon
icon completion

πŸ•— Version & Regression Information

VS 17.10.0 P6

⏯ Playground Link

No response

πŸ’» Code

No response

πŸ™ Actual behavior

Icon of Properties is displayed for Parameters:

image

Sometimes it works:

image

Icon of Parameters is displayed for Classes/Interfaces:

image

Icon of Parameters is displayed for Local Variables:

image

πŸ™‚ Expected behavior

Correct icons are displayed in the member list.

Additional information about the issue

No response

@RyanCavanaugh RyanCavanaugh added the Needs Investigation This issue needs a team member to investigate its status. label May 1, 2024
@Peter-Juhasz
Copy link
Author

One more case:

Icon of Properties is displayed for Functions (among completions):

image

While the correct icon is displayed in quick info:

image

@MariaSolOs
Copy link
Member

Hello @Peter-Juhasz! Given that this issue is specific to Visual Studio's completion, could you please move this discussion to a new issue in https://developercommunity.visualstudio.com/VisualStudio? Thank you!

@Peter-Juhasz
Copy link
Author

Hi @MariaSolOs,

I reported the issue here for the following reasons:

  • Since Visual Studio provides only the hosting and presentation, it is controlled by the language service what to display. In this case, it is the responsibility of the TypeScript language service to choose the correct icons what Visual Studio should display. The same way, if there is an issue only with TypeScript in VSCode, the issue won't belong to the VS Code repo I guess, but here. And on the videos I've provided you can clearly see that it works very differently in different settings. So, my assumption was that the issue is with the TypeScript language service, it selects the icons incorrectly for the completions items to display in same cases (while it works correctly for the quick info), and not with Visual Studio.
  • The language service is implemented in this repo, and I have found many similar issues related to completion and tracked here.
  • I had a very bad experience with the VS reporting earlier, even when detailed reproduction, recordings are provided, they are closing them blindly usually with "not enough info" and that's it.

If you are confident that the issue is with Visual Studio, could you route it to the appropriate team, please? You can provide much more insider details than me, even if it slips only on the integration of the language service and VS. Thank you.

@joj
Copy link
Member

joj commented May 1, 2024

Hi Peter!

Both Maria and I work in the team that provides TypeScript and JavaScript experiences in VS. I'm sorry we haven't provided the level of answers you expected before, we try our best.

We know where the issue is here, and we would prefer to be tracking in the right systems. If you can create an issue in developer community for this and copy the link here, I'll make sure it gets immediately routed to us. Just copying and pasting this should be fine, you did an awesome job in explaining what the issue is.

Thanks!
J

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Investigation This issue needs a team member to investigate its status.
Projects
None yet
Development

No branches or pull requests

4 participants