Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Salsa Feature Request: Support 'fuzzy' go to definition when not using commonJS #9737

Closed
egamma opened this issue Jul 14, 2016 · 1 comment
Closed

Salsa Feature Request: Support 'fuzzy' go to definition when not using commonJS #9737

egamma opened this issue Jul 14, 2016 · 1 comment
Labels
Domain: JavaScript The issue relates to JavaScript specifically Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. In Discussion Not yet reached consensus Suggestion An idea for TypeScript VS Code Tracked There is a VS Code equivalent to this issue

Comments

@egamma
Copy link
Member

egamma commented Jul 14, 2016

When a JS project doesn't use CommonJS as the module system then there is no support for 'go to definition'. Similar as is done for Intellisense where Salsa proposes global symbols that match, Salsa should provide some 'fuzzy' definition locations of a symbol.

This extension is an attempt to fill this gap. However, it is limited and it uses a full text search with some regular expression matching for location. Salsa could do much better than this.
@waderyan waderyan added the VS Code Tracked There is a VS Code equivalent to this issue label Sep 21, 2016
@mhegazy mhegazy added Suggestion An idea for TypeScript Salsa In Discussion Not yet reached consensus labels Dec 15, 2016
@waderyan waderyan mentioned this issue Dec 16, 2016
Closed
@weswigham weswigham added Domain: JavaScript The issue relates to JavaScript specifically and removed Salsa labels Nov 29, 2018
@DanielRosenwasser DanielRosenwasser added the Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. label Nov 8, 2019
@RyanCavanaugh
Copy link
Member

Haven't seen other feedback on this; I think this has been addressed by a change in the default module settings of inferred projects. Closing since there's no repro to validate with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: JavaScript The issue relates to JavaScript specifically Domain: Symbol Navigation Relates to go-to-definition, find-all-references, highlighting/occurrences. In Discussion Not yet reached consensus Suggestion An idea for TypeScript VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@egamma @DanielRosenwasser @waderyan @weswigham @RyanCavanaugh @mhegazy