Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't relate unmatched parameter positions in signatures #41308

Merged
merged 3 commits into from
Oct 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/compiler/checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16156,8 +16156,9 @@ namespace ts {
const restIndex = sourceRestType || targetRestType ? paramCount - 1 : -1;

for (let i = 0; i < paramCount; i++) {
const sourceType = i === restIndex ? getRestTypeAtPosition(source, i) : getTypeAtPosition(source, i);
const targetType = i === restIndex ? getRestTypeAtPosition(target, i) : getTypeAtPosition(target, i);
const sourceType = i === restIndex ? getRestTypeAtPosition(source, i) : tryGetTypeAtPosition(source, i);
const targetType = i === restIndex ? getRestTypeAtPosition(target, i) : tryGetTypeAtPosition(target, i);
if (sourceType && targetType) {
// In order to ensure that any generic type Foo<T> is at least co-variant with respect to T no matter
// how Foo uses T, we need to relate parameters bi-variantly (given that parameters are input positions,
// they naturally relate only contra-variantly). However, if the source and target parameters both have
Expand Down Expand Up @@ -16187,6 +16188,7 @@ namespace ts {
}
result &= related;
}
}

if (!(checkMode & SignatureCheckMode.IgnoreReturnTypes)) {
// If a signature resolution is already in-flight, skip issuing a circularity error
Expand Down
13 changes: 13 additions & 0 deletions tests/baselines/reference/unmatchedParameterPositions.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
//// [unmatchedParameterPositions.ts]
// Repros from #40251

declare let s: (...items: never[]) => never[];
let t1: () => unknown[] = s;
let t2: (...args: []) => unknown[] = s;


//// [unmatchedParameterPositions.js]
"use strict";
// Repros from #40251
var t1 = s;
var t2 = s;
16 changes: 16 additions & 0 deletions tests/baselines/reference/unmatchedParameterPositions.symbols
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
=== tests/cases/compiler/unmatchedParameterPositions.ts ===
// Repros from #40251

declare let s: (...items: never[]) => never[];
>s : Symbol(s, Decl(unmatchedParameterPositions.ts, 2, 11))
>items : Symbol(items, Decl(unmatchedParameterPositions.ts, 2, 16))

let t1: () => unknown[] = s;
>t1 : Symbol(t1, Decl(unmatchedParameterPositions.ts, 3, 3))
>s : Symbol(s, Decl(unmatchedParameterPositions.ts, 2, 11))

let t2: (...args: []) => unknown[] = s;
>t2 : Symbol(t2, Decl(unmatchedParameterPositions.ts, 4, 3))
>args : Symbol(args, Decl(unmatchedParameterPositions.ts, 4, 9))
>s : Symbol(s, Decl(unmatchedParameterPositions.ts, 2, 11))

16 changes: 16 additions & 0 deletions tests/baselines/reference/unmatchedParameterPositions.types
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
=== tests/cases/compiler/unmatchedParameterPositions.ts ===
// Repros from #40251

declare let s: (...items: never[]) => never[];
>s : (...items: never[]) => never[]
>items : never[]

let t1: () => unknown[] = s;
>t1 : () => unknown[]
>s : (...items: never[]) => never[]

let t2: (...args: []) => unknown[] = s;
>t2 : () => unknown[]
>args : []
>s : (...items: never[]) => never[]

7 changes: 7 additions & 0 deletions tests/cases/compiler/unmatchedParameterPositions.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// @strict: true

// Repros from #40251

declare let s: (...items: never[]) => never[];
let t1: () => unknown[] = s;
let t2: (...args: []) => unknown[] = s;