Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review style of Master Detail page #1809

Closed
prupipho opened this issue May 13, 2021 · 1 comment
Closed

Review style of Master Detail page #1809

prupipho opened this issue May 13, 2021 · 1 comment
Assignees
@prupipho
Labels
enhancement Improving an existing feature react native WTS Platform style-bug UI bugs (e.g. CSS)
Milestone
0.7

Comments

@prupipho
Copy link
Contributor

prupipho commented May 13, 2021 •
edited

Describe the bug
When creating a react-native app using Web Template Studio with a Master Detail page.
In the Windows application, the menu and the page look a bit weird on wide screens.
We should have a look and review if it can look a little bit nicer.

Notice the item detail page looks a bit weird with the horizontal margin.
Not sure about the menu width too, maybe it shouldn´t grow that much either.

Screenshots

MicrosoftTeams-image (1)

MicrosoftTeams-image (2)

New display

MasterDetail-new
@prupipho prupipho added bug Something is broken react native WTS Platform labels May 13, 2021
@prupipho prupipho added this to the 0.7 milestone May 13, 2021
@ghost ghost added the needs-triage For new issues that are raised to get reviewed by internal Microsoft employees label May 13, 2021
@prupipho prupipho removed the needs-triage For new issues that are raised to get reviewed by internal Microsoft employees label May 13, 2021
@sibille sibille added enhancement Improving an existing feature style-bug UI bugs (e.g. CSS) and removed bug Something is broken labels May 14, 2021
@prupipho prupipho self-assigned this May 17, 2021
@prupipho prupipho added the In Progress Indicates the issue is currently being worked on label May 18, 2021
@prupipho prupipho changed the title Review style of Master Detail page in a generated React Native Windows app Review style of Master Detail page May 18, 2021
This was referenced May 18, 2021
Merged
Merged
@prupipho prupipho added Ready for Testing and removed In Progress Indicates the issue is currently being worked on labels May 18, 2021
@prupipho
Copy link
Contributor Author

prupipho commented Jun 16, 2021 •
edited

Review in nightly build:

Templates version: 0.3.21167.1
Wizard version: 0.3.2116701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prupipho prupipho

Labels
enhancement Improving an existing feature react native WTS Platform style-bug UI bugs (e.g. CSS)
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
2 participants
@prupipho @sibille