Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitButton Page TextBox adds New Lines #372

Closed
1 of 13 tasks
carlos-zamora opened this issue Mar 4, 2020 · 3 comments
Closed
1 of 13 tasks

SplitButton Page TextBox adds New Lines #372

carlos-zamora opened this issue Mar 4, 2020 · 3 comments

Comments

@carlos-zamora
Copy link
Member

Describe the bug
Focusing on the text box for the SplitButton page adds a new line

Steps to reproduce the bug

Steps to reproduce the behavior:

  1. Go to 'SplitButton' page
  2. Click on the text box
  3. Click on the code under the text box
  4. repeat steps 2+3 as desired

Expected behavior
No newlines added

Actual behavior
Newlines get added on focus

Screenshots
XamlControlsGalleryBug

Version Info
Windows Version 2004 19577.1002

Gallery version (found on Settings page):
1.2.13.0

Windows 10 version:

  • Insider Build (xxxxx)
  • November 2019 Update (18363)
  • May 2019 Update (18362)
  • October 2018 Update (17763)
  • April 2018 Update (17134)
  • Fall Creators Update (16299)
  • Creators Update (15063)
  • Anniversary Update (14393)

Device form factor:

  • Desktop
  • Mobile
  • Xbox
  • Surface Hub
  • IoT
@stmoy
Copy link
Contributor

stmoy commented Mar 4, 2020

image

@chingucoding - I think this might be related to #294, can you take a look?

@marcelwgn
Copy link
Collaborator

That was actually introduced with #144 . However this is an issue with the underlying RichEditBox, which is currently tracked here: microsoft/microsoft-ui-xaml#1941

To restore the color of the text upon focus, we call SetText which adds a new line. Once the behavior of the RichEditBox and TextBox changes, we probably can get rid of that code and the newly added lines shouldn't be an issue anymore.

@marcelwgn
Copy link
Collaborator

Given that we removed that code that caused this with #524 , this issue can be closed now.

@stmoy stmoy closed this as completed Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants