Fix typo with backbutton visibility in NavigationView sample #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agreed. My guess is "history". @YuliKl @MikeHillberg - any ideas? |
stmoy
approved these changes
Dec 6, 2019
Good guess :) I think we made a mistake in naming the property and didn't catch it until the API went public. Changing public APIs in the SDK isn't really a supported scenario. We have opportunity to fix this with WinUI 3 but need to wait to introduce this logical but breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed typo "BackButtonVisibility" to "IsBackButtonVisible".
BTW: Why is "IsBackButtonVisible" a Visibility and not a boolean? Seems a bit counter intuitive to me. 😅
Motivation and Context
Fixes #283
How Has This Been Tested?
Tested manually by starting app and navigating to NavigationView page.
Screenshots (if appropriate):
Types of changes