Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final token concatenation not correct #63

Closed
WebworkApp opened this issue Feb 14, 2020 · 2 comments
Closed

Final token concatenation not correct #63

WebworkApp opened this issue Feb 14, 2020 · 2 comments

Comments

@WebworkApp
Copy link

WebworkApp commented Feb 14, 2020

Hello,

Final token concatenation is not correct in class zcl_rest_utility_class line 904.

The sig parameter is repeated and sr is missing:
CONCATENATE 'SharedAccessSignature sig=' lv_encoded_base_address '&sig=' lv_sign '&se=' lv_new_expiry_adf '&skn='wa_policy-policy INTO lv_final_token.

Should be corrected for:
CONCATENATE 'SharedAccessSignature sr=' lv_encoded_base_address '&sig=' lv_sign '&se=' lv_new_expiry_adf '&skn='wa_policy-policy INTO lv_final_token.

Thanks for this framework, it save my day.
Nuno Morais

@krdash
Copy link
Contributor

krdash commented Feb 18, 2020

Thanks @WebworkApp - Nuno Morais for your feedback. Now code correction has been done to include signature string for Azure servicebus along with Azure eventhub.
we are also working on the modularization of reprocessing functionality. we would keep you posted on this soon. For open source contribution, please refer the installation guide of abapGit.
https://github.com/larshp/abapGit
Thanks, Krishna

@krdash
Copy link
Contributor

krdash commented Feb 25, 2020

Closing the issue as correction has been merged into master branch. Please let us know in case you see any issues.
Thanks, Krishna

@krdash krdash closed this as completed Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants