Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaces #8

Closed
larshp opened this issue Jun 2, 2018 · 9 comments
Closed

Namespaces #8

larshp opened this issue Jun 2, 2018 · 9 comments

Comments

@larshp
Copy link
Contributor

larshp commented Jun 2, 2018

Hi,
The repository contains some objects with quite generic names, eg:
FUGR ZREST
TABL ZREGISTER
DOMA ZCLASSNAME
DTEL ZCHAR75
DTEL ZORIGINAL
DTEL ZURI
DTEL ZUNAME
For these, there is a theoretical chance that the customer already has an object with identical names in their system.

I recommend prefixing objects to lower the risk, eg.
FUGR Z_AZURE_REST
TABL Z_AZURE_REGISTER
DOMA Z_AZURE_CLASSNAME
DTEL Z_AZURE_CHAR75
DTEL Z_AZURE_ORIGINAL
DTEL Z_AZURE_URI
DTEL Z_AZURE_UNAME
or something similar

@larshp larshp changed the title namespaces Namespaces Jun 2, 2018
@krdash
Copy link
Contributor

krdash commented Jun 2, 2018

Thanks for the feedback. We are working on this.

@krdash
Copy link
Contributor

krdash commented Jun 2, 2018

@larshp -
We are looking into your suggestion for getting a unique Namespace.
I have one query on ABAPGit to understand whether ABAPGit would show any object overwriting warnings while doing the pull or clone from the repository to SAP system. Thanks

@larshp
Copy link
Contributor Author

larshp commented Jun 2, 2018

unique namespace: in my opinion it is easier just to prefix

overwrite: yes it shows warnings if the objects it tries to overwrite are outside of the expected package hierarchy(main repo package)

@bigld
Copy link
Contributor

bigld commented Jun 4, 2020

@krdash So, is ZxxADFxx the actual prefix Namespace (e.g. ZCL_ADF_..., ZADF_S_STRUC...)?
Should we move ZREST to ZADF one by one?

@atarigui
Copy link

What is the status on this? It seems to me that the correct way to do it is to introduce a proper name space, instead of customer namespace Z...
For instance /AZURE/
Everything else will cause problems at some point...

@bigld
Copy link
Contributor

bigld commented Nov 17, 2021

Namespace must be Z or Y!
For reserved Namespaces like /AZURE/ one needs special key (producer/repair) to create objects in this namespace!

@atarigui
Copy link

The problem is that this comes with name conflicts, which can not be prevented as long as the objects are in Z (customer) name space. ref other issue #41 . Maybe the repair key could be shared (similar to DEMO objects in SAP)? See for instance this

@vikasbansal2022
Copy link
Contributor

Thanks @larshp for the feedback,

We are working towards unified namespace for the next release will keep you posted.

Regards,
Vikas

@larshp
Copy link
Contributor Author

larshp commented Nov 30, 2022

cool

one tip, you can setup abaplint to automatically check the objects have the preferred prefix, example at https://github.com/abapGit/abapGit/blob/main/abaplint.json#L335-L339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants