Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with inputurls if auth is enabled #1809

Closed
DaveTryon opened this issue Sep 8, 2023 · 2 comments
Closed

Problem with inputurls if auth is enabled #1809

DaveTryon opened this issue Sep 8, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@DaveTryon
Copy link
Contributor

Describe the bug

When combining auth + multiple pages in the inputurls parameter, only the first value of inputurls is honored. Multiple values in inputurls work as expected without auth

To Reproduce

  1. Create a pipeline that requires auth
  2. Use the inputurls parameter to specify 2 pages
  3. Run the pipeline
  4. See that only 1 pipeline ran

(Ideally this scenario should be in our pipeline testing)

CodePen repro example

Expected behavior

inputurls operation should be independent of auth

Screenshots

Context (please complete the following information)

  • OS Name & Version:
  • Azure DevOps Extension Version & Environment:
  • Browser Version:
  • Target Page:

Are you willing to submit a PR?

Did you search for similar existing issues?

Additional context

@DaveTryon DaveTryon added the bug Something isn't working label Sep 8, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the status: new This issue is new and requires triage by DRI. label Sep 8, 2023
@DaveTryon
Copy link
Contributor Author

We definitely want to support multiple inputUrls and auth, providing that the same auth is used for all scans

@DaveTryon DaveTryon removed the status: new This issue is new and requires triage by DRI. label Sep 27, 2023
@DaveTryon DaveTryon removed their assignment Sep 27, 2023
@DaveTryon
Copy link
Contributor Author

We do support auth and multiple values in inputUrls. What we do not support is crawling single page applications (SPA's) that use hash routing. That was precisely the scenario that led to this issue being reported, but we didn't realize the connection at that time. Closing this out.

@DaveTryon DaveTryon closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant