Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help text from baselining should exclude unsupported --updateBaseline option #944

Closed
DaveTryon opened this issue Nov 1, 2021 · 1 comment · Fixed by #1226
Closed

Help text from baselining should exclude unsupported --updateBaseline option #944

DaveTryon opened this issue Nov 1, 2021 · 1 comment · Fixed by #1226
Labels
status: resolved This issue has been merged into main and deployed to canary.

Comments

@DaveTryon
Copy link
Contributor

DaveTryon commented Nov 1, 2021

When running the ADO extension with baselining, we get the following message from the scanner:

To update the baseline with these changes, either rerun with --updateBaseline or copy the updated baseline file to /home/vsts/work/1/s/test.baseline

The --updateBaseline option makes sense when running the scanner CLI. It doesn't make sense when running the scanner from inside the ADO extension. We should have a way for the scanner to exclude the --updateBaseline help when running from the extension.

@ghost ghost added the status: new This issue is new and requires triage by DRI. label Nov 1, 2021
@ghost ghost assigned karanbirsingh Nov 1, 2021
@DaveTryon DaveTryon changed the title Help text from baselining references unsupported --updateBaseline option Help text from baselining should not reference unsupported --updateBaseline option Nov 1, 2021
@karanbirsingh karanbirsingh added the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Nov 2, 2021
@ghost ghost assigned asksep Nov 2, 2021
@ghost
Copy link

ghost commented Nov 2, 2021

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@ghost ghost removed the status: new This issue is new and requires triage by DRI. label Nov 2, 2021
@karanbirsingh karanbirsingh removed their assignment Nov 2, 2021
@asksep asksep added status: ready for work This issue is ready to be worked on. and removed status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. labels Nov 9, 2021
@DaveTryon DaveTryon changed the title Help text from baselining should not reference unsupported --updateBaseline option Help text from baselining should exclude unsupported --updateBaseline option Dec 3, 2021
@pownkel pownkel self-assigned this Jun 29, 2022
@pownkel pownkel added status: active This issue is currently being worked on by someone. and removed status: ready for work This issue is ready to be worked on. labels Jun 29, 2022
@pownkel pownkel added status: resolved This issue has been merged into main and deployed to canary. and removed status: active This issue is currently being worked on by someone. labels Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: resolved This issue has been merged into main and deployed to canary.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants