You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've identified the 2 following cases that are poorly represented in the PR comments that are created by ADO extension version 1.1.1:
Scenario 1: PR corrects some (but not all) violations
This occurs when:
A baseline file exists
The PR addresses some (but not all) of the violations in the baseline
No new violations are introduced
The current code generates the "no new failures" PR message, which makes no mention of changes or updating the baseline file. A more appropriate PR comment would include verbiage about updating the baseline file, as well as a summary of what violations have been removed. These comments should help the PR author understand if the actual results of the PR match the anticipated results of the PR.
Scenario 2: PR modifies some violations without fixing them
This occurs when:
A baseline file exists
The PR includes a change that removes some existing violations but creates new ones. Since violations are specific to both the URL and HTML, this could happen if the HTML around a violation changes or if a page containing violations gets a different URL.
The current code generates the "new failures found" PR message, with no comment about the comments that have been fixed. It tells the user to update the PR, but makes no mention of the violations that no longer exist.
The text was updated successfully, but these errors were encountered:
This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!
We've identified the 2 following cases that are poorly represented in the PR comments that are created by ADO extension version 1.1.1:
Scenario 1: PR corrects some (but not all) violations
This occurs when:
The current code generates the "no new failures" PR message, which makes no mention of changes or updating the baseline file. A more appropriate PR comment would include verbiage about updating the baseline file, as well as a summary of what violations have been removed. These comments should help the PR author understand if the actual results of the PR match the anticipated results of the PR.
Scenario 2: PR modifies some violations without fixing them
This occurs when:
The current code generates the "new failures found" PR message, with no comment about the comments that have been fixed. It tells the user to update the PR, but makes no mention of the violations that no longer exist.
The text was updated successfully, but these errors were encountered: