-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "Text legibility" category #2655
Comments
This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights! |
This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights! |
Thanks for the suggestion @patrickhlauke! @LiLoDavis thoughts for changing the title of the test? |
if they were all to still stay within the same category, maybe (though a bit ugly) renaming to a combined "Content adaptability / text legibility"? hover/focus would still feel like the odd one out though to an extent... |
We'll need the test name to be short. At this time, the longest test name is Automated checks. |
Going forward though, I think that would be the preferred option...but understand that it's quite a breaking change.
Doesn't completely capture some of the nuance (e.g. could argue that for "orientation", stuff is still "viewable", just that you potentially are forced to tilt your head on your hard-mounted device to see it properly), but as I can't come up with anything more suitable (closest I had was "Adaptable / viewable" but that still doesn't fit the current layout/length), I guess I could live with that for the time being. (it does still feel odd at a very high level that text contrast would not be under contrast though...but maybe the more fundamental reshuffling of categories is something that could be considered for a future version) |
Perfect, just to summarize, this requires to change the Test title from "Text Legibility" to "Viewable Content" |
This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights! |
I believe that's correct. |
after reviewing this with the board, the suggestion was to use "Adaptable content". |
guessing that moving text contrast to the contrast category would still be too big a change though, right? |
|
Hi @patrickhlauke this issue is now fixed in our Canary extension |
The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights! |
Just tried the canary extension ... looking good! The "Getting started" explanation for 17 Adaptable content could probably do with a slight rewrite, but I'll suggest something in a separate issue/PR. And yes, still holding out hope that in the far future, 17.3 Contrast will be moved to 24 Contrast :) Long story short: perfect, thank you. |
Is your feature request related to a problem? Please describe.
The current category name of "Text legibility" does not sufficiently/accurately convey what some of the tests/SCs are about.
High Contrast Mode, Orientation, Reflow (see #2654) and Hover / focus content are not solely about text, but content in general.
Having these grouped under "text legibility" may lead auditors to the false impression that any problems under those tests relating to non-text content are ok/not applicable.
Describe the desired outcome
Ideally, find a more suitable category name (and generalise the high-level description). Perhaps something like "Page adaptability", "Content adaptability" or similar. However, this admittedly makes "Contrast" and "Hover / focus content" stand out again/doesn't quite make them fit.
The Contrast test could logically be moved into the "Contrast" category.
"Hover / focus content" could potentially be placed under "Custom widgets"
The text was updated successfully, but these errors were encountered: