Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Text legibility" category #2655

Closed
patrickhlauke opened this issue May 10, 2020 · 15 comments
Closed

Rename "Text legibility" category #2655

patrickhlauke opened this issue May 10, 2020 · 15 comments
Assignees
Labels
feature request status: resolved This issue has been merged into main and deployed to canary.

Comments

@patrickhlauke
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The current category name of "Text legibility" does not sufficiently/accurately convey what some of the tests/SCs are about.

High Contrast Mode, Orientation, Reflow (see #2654) and Hover / focus content are not solely about text, but content in general.

Having these grouped under "text legibility" may lead auditors to the false impression that any problems under those tests relating to non-text content are ok/not applicable.

Describe the desired outcome

Ideally, find a more suitable category name (and generalise the high-level description). Perhaps something like "Page adaptability", "Content adaptability" or similar. However, this admittedly makes "Contrast" and "Hover / focus content" stand out again/doesn't quite make them fit.

The Contrast test could logically be moved into the "Contrast" category.

"Hover / focus content" could potentially be placed under "Custom widgets"

@msft-github-bot msft-github-bot added the status: new This issue is new and requires triage by DRI. label May 10, 2020
@karanbirsingh karanbirsingh added the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label May 11, 2020
@msft-github-bot
Copy link
Collaborator

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@msft-github-bot msft-github-bot removed the status: new This issue is new and requires triage by DRI. label May 11, 2020
@karanbirsingh karanbirsingh removed their assignment May 11, 2020
@ferBonnin ferBonnin added the status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. label May 11, 2020
@msft-github-bot
Copy link
Collaborator

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

@msft-github-bot msft-github-bot removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label May 11, 2020
@ferBonnin
Copy link
Contributor

Thanks for the suggestion @patrickhlauke!

@LiLoDavis thoughts for changing the title of the test?
Changing requirements from one test to another is not trivial work (specially considering what happens for users that have an assessment in progress) but we could change the test title to something that is more comprehensive

@patrickhlauke
Copy link
Contributor Author

if they were all to still stay within the same category, maybe (though a bit ugly) renaming to a combined "Content adaptability / text legibility"? hover/focus would still feel like the odd one out though to an extent...

@LiLoDavis
Copy link

We'll need the test name to be short. At this time, the longest test name is Automated checks.
How about Viewable content?

@patrickhlauke
Copy link
Contributor Author

Changing requirements from one test to another is not trivial work

Going forward though, I think that would be the preferred option...but understand that it's quite a breaking change.

We'll need the test name to be short. At this time, the longest test name is Automated checks.
How about Viewable content?

Doesn't completely capture some of the nuance (e.g. could argue that for "orientation", stuff is still "viewable", just that you potentially are forced to tilt your head on your hard-mounted device to see it properly), but as I can't come up with anything more suitable (closest I had was "Adaptable / viewable" but that still doesn't fit the current layout/length), I guess I could live with that for the time being.

(it does still feel odd at a very high level that text contrast would not be under contrast though...but maybe the more fundamental reshuffling of categories is something that could be considered for a future version)

@ferBonnin ferBonnin moved this from Needs triage to Needs Investigation in Accessibility Insights feature board (DEPRECATED - DO NOT USE!) May 18, 2020
@ferBonnin
Copy link
Contributor

Perfect, just to summarize, this requires to change the Test title from "Text Legibility" to "Viewable Content"

@ferBonnin ferBonnin added the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label May 18, 2020
@msft-github-bot
Copy link
Collaborator

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@msft-github-bot msft-github-bot removed the status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. label May 18, 2020
@ferBonnin ferBonnin moved this from Needs Investigation to Needs triage in Accessibility Insights feature board (DEPRECATED - DO NOT USE!) May 18, 2020
@LiLoDavis
Copy link

Perfect, just to summarize, this requires to change the Test title from "Text Legibility" to "Viewable Content"

I believe that's correct.

@ferBonnin
Copy link
Contributor

after reviewing this with the board, the suggestion was to use "Adaptable content".

@patrickhlauke
Copy link
Contributor Author

guessing that moving text contrast to the contrast category would still be too big a change though, right?

@ferBonnin
Copy link
Contributor

guessing that moving text contrast to the contrast category would still be too big a change though, right?
yes; doing this correctly, to not break any users that have an in progress assessment, is something complex. It is in our radar but we need to weight this effort against other possible features.

@ferBonnin ferBonnin added the status: ready for work This issue is ready to be worked on. label Jun 30, 2020
@msft-github-bot msft-github-bot removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Jun 30, 2020
@LiLoDavis LiLoDavis removed their assignment Jul 23, 2020
@JGibson2019 JGibson2019 assigned JGibson2019 and unassigned ferBonnin Aug 4, 2020
@JGibson2019 JGibson2019 added status: active This issue is currently being worked on by someone. and removed status: ready for work This issue is ready to be worked on. labels Aug 4, 2020
@JGibson2019 JGibson2019 added status: resolved This issue has been merged into main and deployed to canary. and removed status: active This issue is currently being worked on by someone. labels Aug 6, 2020
@JGibson2019 JGibson2019 assigned ferBonnin and unassigned JGibson2019 Aug 6, 2020
@ferBonnin
Copy link
Contributor

Hi @patrickhlauke this issue is now fixed in our Canary extension

@ferBonnin ferBonnin added the status: needs author feedback This issue requires additional information from the issue author. label Aug 6, 2020
@msft-github-bot
Copy link
Collaborator

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!

@patrickhlauke
Copy link
Contributor Author

Just tried the canary extension ... looking good! The "Getting started" explanation for 17 Adaptable content could probably do with a slight rewrite, but I'll suggest something in a separate issue/PR. And yes, still holding out hope that in the far future, 17.3 Contrast will be moved to 24 Contrast :)

Long story short: perfect, thank you.

@msft-github-bot msft-github-bot added status: needs attention The author has provided additional feedback and now requires attention. and removed status: needs author feedback This issue requires additional information from the issue author. labels Aug 6, 2020
@ferBonnin ferBonnin removed the status: needs attention The author has provided additional feedback and now requires attention. label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request status: resolved This issue has been merged into main and deployed to canary.
Projects
None yet
Development

No branches or pull requests

6 participants