Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue details dialog button is upside down #490

Closed
ferBonnin opened this issue Apr 1, 2019 · 4 comments
Closed

issue details dialog button is upside down #490

ferBonnin opened this issue Apr 1, 2019 · 4 comments
Labels
bug Something isn't working status: resolved This issue has been merged into main and deployed to canary.

Comments

@ferBonnin
Copy link
Contributor

Describe the bug

buttons are not usable in the issue details on target page

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://uifabric-prod.azurewebsites.net/?example=jhkjhkj#/components/toggle
  2. run automated checks
  3. Click one failure to open issue details
  4. See error

Expected behavior

buttons should look the same as in any other page

Screenshots

a screenshot of the issue details dialog

Extension (please complete the following information)

  • OS: Windows
  • Version: 2.1.2
  • Chrome Version : 73.0.3683.86

Are you willing to submit a PR?

If asked, will you be willing to submit a PR to fix this bug? No

Did you search for similar existing issues?

Did you search for similar issues in our github issues or on stackoverflow
Yes
@ferBonnin ferBonnin added the bug Something isn't working label Apr 1, 2019
@msft-github-bot msft-github-bot added the status: new This issue is new and requires triage by DRI. label Apr 1, 2019
@peterdur
Copy link
Contributor

peterdur commented Apr 1, 2019

DRI triage: Bug has sufficient information, not a DRI issue.

@peterdur peterdur added status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. and removed status: new This issue is new and requires triage by DRI. labels Apr 1, 2019
@peterdur
Copy link
Contributor

peterdur commented Apr 3, 2019

Assigning to PM (bot did not pick this up)

@peterdur peterdur assigned ferBonnin and unassigned peterdur Apr 3, 2019
@ferBonnin ferBonnin removed their assignment Apr 4, 2019
@ferBonnin ferBonnin added status: ready for work This issue is ready to be worked on. and removed status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. labels Apr 4, 2019
@ferBonnin
Copy link
Contributor Author

@lisli1 looks like this got fixed with your PR, can you confirm?

@lisli1
Copy link
Contributor

lisli1 commented Apr 12, 2019

I can't repro this bug anymore, so I will mark it as resolved.

@lisli1 lisli1 added the status: resolved This issue has been merged into main and deployed to canary. label Apr 12, 2019
@msft-github-bot msft-github-bot removed the status: ready for work This issue is ready to be worked on. label Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working status: resolved This issue has been merged into main and deployed to canary.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@peterdur @ferBonnin @msft-github-bot @lisli1