Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the aria-required-children rule flags child elements that are not in the accessibility tree as needing to be removed #7273

Open
stmillMSFT opened this issue Mar 13, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@stmillMSFT
Copy link

Describe the bug

When evaluating the aria-required-children rule, the tool reports elements that are not in the accessibility tree (via aria-hidden=true) as needing to be removed.
image

Your own docs even list removal from the accessibility tree as a valid way to pass the rule.
image

But setting aria-hidden="true" on the element (which removes it from the accessibility tree), does not prevent the element from being flagged as needing to be removed.

To Reproduce

Run fastpass on the codepen below. Two false-positives get reported.

CodePen repro example

https://codepen.io/stmill/pen/VwNKLKQ
(this is not quite a minimal repro, since I'm trying to reuse it to repro a related bug as well)

This is also present on this page: https://developer.microsoft.com/en-us/fluentui#/controls/web/detailslist/grouped

Expected behavior

Elements that are not in the accessibility tree should not be included for this rule. The current behavior does not match the aria spec or your own documentation.

Screenshots

Included above.

Context (please complete the following information)

  • OS Name & Version: Windows 11 Enterprise 22H2 Build 22621.3296
  • AI-Web Version & Environment: 2.41.0
  • Browser Version: Edge 122.0.2365.80
  • Target Page: Cannot be shared here. If you're a Microsoft FTE, ping me (stmill), and I can share more.

Are you willing to submit a PR?

No

Did you search for similar existing issues?

Yes

Additional context

@stmillMSFT stmillMSFT added the bug Something isn't working label Mar 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the status: new This issue is new and requires triage by DRI. label Mar 13, 2024
@DaveTryon DaveTryon removed the status: new This issue is new and requires triage by DRI. label Mar 18, 2024
@DaveTryon
Copy link
Contributor

Let's try to understand what is happening here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Accepted
Development

No branches or pull requests

3 participants