Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab stops test does not draw the first tab stop indicator. #151

Closed
risanaka opened this issue Mar 4, 2019 · 12 comments
Closed

Tab stops test does not draw the first tab stop indicator. #151

risanaka opened this issue Mar 4, 2019 · 12 comments
Labels
bug Something isn't working status: resolved This issue has been merged into main.

Comments

@risanaka
Copy link
Contributor

risanaka commented Mar 4, 2019

Describe the bug
When running the tab stops test, the number (1) isn't shown on an element if it already has focus when you turn on the tab stops test.

To Reproduce
Steps to reproduce the behavior:

  1. Open the Enterprise app.
  2. In Customers, select + New.
  3. In New customer, set focus in the First name field.
  4. Turn on Record tab stops.
  5. Press the Tab key once.

Expected behavior
The number (1) appears on the First name field.

Actual behavior
The number (1) appears on the Last name field.

Screenshots or .GIF
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. Windows 10 1809] (Get the version by running winver from the command line)
  • Accessibility Insights for Windows Version:
  • Target Application: [e.g. chrome, safari]
  • Target Application Version: [e.g. 22]

Additional context
Priority requested -
Add any other context about the problem here.

@msft-github-bot msft-github-bot added the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Mar 4, 2019
@mslonli mslonli removed their assignment Mar 4, 2019
@msft-github-bot
Copy link
Collaborator

Thank you for filing this issue. We will triage it in the weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@risanaka risanaka added status: needs investigation This issue requires investigation by the Accessibility Insights team. and removed status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. labels Mar 4, 2019
@risanaka
Copy link
Contributor Author

risanaka commented Mar 4, 2019

We need to revisit the overall Tab stops UX as we get regular feedback on how to use it. @risanaka to upgrade this to a milestone.

@risanaka risanaka added the feature request New feature or request label Mar 4, 2019
@MinKPark MinKPark changed the title [BUG] Tab stops test does not draw the first tab stop indicator. Tab stops test does not draw the first tab stop indicator. Mar 20, 2019
@MinKPark
Copy link
Contributor

Since it is a feature request, I remove [BUG] from the title.

@risanaka risanaka assigned ferBonnin and unassigned risanaka Apr 2, 2019
@risanaka
Copy link
Contributor Author

risanaka commented Apr 2, 2019

@ferBonnin - this issue has a consistency problem between Web and Windows on how Tab stops is displayed. Can you drive the conversation?

@ferBonnin
Copy link
Contributor

@risanaka for sure :)

@Sirisha-Kommushetty
Copy link

@ferBonnin - Can we connect on this. Seems like a bug that can be fixed for both Windows and Web.

@ferBonnin
Copy link
Contributor

@Sirisha-Kommushetty lets connect. The problem here is that Web and Windows behave differently. (Windows doesnt draw the first tab stop indicator)

@jalkire
Copy link
Contributor

jalkire commented Jun 5, 2019

@Sirisha-Kommushetty @ferBonnin For context, there is no good/intentional reason why Windows doesn't draw the first tab stop. It just happened to be that way. I hope we decide to make the change 👍

@ferBonnin
Copy link
Contributor

@jalkire thanks for the context! :) I agree

@ferBonnin ferBonnin added bug Something isn't working status: ready for work This issue is ready to be worked on. and removed feature request New feature or request labels Jun 10, 2019
@msft-github-bot msft-github-bot removed the status: needs investigation This issue requires investigation by the Accessibility Insights team. label Jun 10, 2019
@ferBonnin
Copy link
Contributor

from conversation with Peter, size of this is probably bug, changing tags and marking ready for work

@jalkire jalkire self-assigned this Jun 20, 2019
@jalkire jalkire added status: active This issue is currently being worked on by someone. and removed status: ready for work This issue is ready to be worked on. labels Jun 20, 2019
@jalkire jalkire added the status: resolved This issue has been merged into main. label Jun 24, 2019
@msft-github-bot msft-github-bot removed the status: active This issue is currently being worked on by someone. label Jun 24, 2019
@jalkire jalkire assigned risanaka and unassigned jalkire Jun 24, 2019
@Sirisha-Kommushetty
Copy link

@risanaka - Could you validate this in the latest canary builds and close it? Thank you!

@Sirisha-Kommushetty Sirisha-Kommushetty removed their assignment Jun 26, 2019
@risanaka
Copy link
Contributor Author

@Sirisha-Kommushetty validated and closing. Thanks for the fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: resolved This issue has been merged into main.
Projects
None yet
Development

No branches or pull requests

7 participants