Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Forward slash missing in the input reader and output writer dockerfiles, causing the builds to fail #246

Open
7 tasks
maniSbindra opened this issue Feb 5, 2019 · 0 comments

Comments

@maniSbindra
Copy link
Member

Issue Template

  • Does your issue follow our Code of Conduct?

  • Ensure you are up-to-date with master.

  • Search existing issues.

  • Part of the project with issues: (ie. Agogosml, Deployment, CLI)

  • Indicate OS, version of Python (Note: Only Python 3.7 is currently supported.)

    • Include versions of tooling where appropriate (Terraform, Kubernetes, Docker, etc.)
  • Steps of reproduce issue. Provide a link to a Github Gist or paste here if short.
    To reproduce use the generate command to generate the template and then look at the input reader and out put writer docker files. both of them will have paths as follows :

FROM ${CONTAINER_REG}agogosml:${AGOGOSML_TAG} as builder

There needs to be a "/" after ${CONTAINER_REG} . because of the path being incorrect, the Azure Devops build fails with the following message

ull access denied for *********.azurecr.ioagogosml, repository does not exist or may require 'docker login'

After adding "/" build is successful

I will submit PR for this as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant