Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues in chapter 10 #75

Closed
YanjieGao opened this issue Apr 12, 2022 · 29 comments
Closed

Issues in chapter 10 #75

YanjieGao opened this issue Apr 12, 2022 · 29 comments
Assignees

Comments

@YanjieGao
Copy link
Contributor

Hi Hui , 请增加类似摘要的一些问题,吸引读者。例如,RL的引出,Recall哪些传统问题,重要性motivation之类的words。Please reference chapter 13

image

@YanjieGao
Copy link
Contributor Author

大小写一致,例如都用小写

image

@YanjieGao
Copy link
Contributor Author

请增加中英文解释概念进术语表

image

@YanjieGao
Copy link
Contributor Author

Add some words和下一章节关联

image

@YanjieGao
Copy link
Contributor Author

如果两章内容都较少,两章可以合并并更新主readme

image

@YanjieGao
Copy link
Contributor Author

cores?

image

@YanjieGao
Copy link
Contributor Author

中文化
image

@YanjieGao
Copy link
Contributor Author

可以统一检查大小写一致问题,例如都统一 小 写

image

@YanjieGao
Copy link
Contributor Author

图片调到较为居上,可以防止后面感觉缺文字

image

@YanjieGao
Copy link
Contributor Author

章节内或结尾可以适当增加一些启发性问题,启发读者思考。
image

@YanjieGao
Copy link
Contributor Author

高亮突出分级标题
image

@YanjieGao
Copy link
Contributor Author

图表可以用markdown语法标识,
章节风格就容易统一了

image

@YanjieGao
Copy link
Contributor Author

增加章节小节

image

@YanjieGao
Copy link
Contributor Author

改为 markdown语法表,统一格式

image

@YanjieGao
Copy link
Contributor Author

章节介绍或者目录,请参考chapter7.8模板
image

@YanjieGao
Copy link
Contributor Author

使用 markdown table语法

image

@YanjieGao
Copy link
Contributor Author

请用''' ''' markdown语法呈现代码,方便各章节统一格式

image

@YanjieGao
Copy link
Contributor Author

图名字

image

@YanjieGao
Copy link
Contributor Author

增加小节序号,让其结构性更强

image

@YanjieGao
Copy link
Contributor Author

章节小节
image

@YanjieGao
Copy link
Contributor Author

YanjieGao commented Apr 14, 2022

Hi Hui,请把lab补充进章节 https://github.com/microsoft/AI-System/tree/main/Labs/AdvancedLabs/Lab9
参考形式参考chapter7,8

@YanjieGao
Copy link
Contributor Author

https://github.com/microsoft/AI-System/blob/main/Textbook/src/Checker.py
Please avoid these errors.
We will try to add more in this like "Coding conventions"

@YanjieGao
Copy link
Contributor Author

YanjieGao commented Apr 20, 2022

image
缺少对称概念

@YanjieGao
Copy link
Contributor Author

item之间内容描述可遵循同样格式

image

@YanjieGao
Copy link
Contributor Author

#85

@YanjieGao
Copy link
Contributor Author

#86

@YanjieGao
Copy link
Contributor Author

Dear Author, 请同时阅读其他章节内容, 我们需要章节间内容的一些叙事铺垫, 内容呼应和内容去重,当前图书不太适合完全孤立的书写各章,请大家和各章节auther再就这些如果发现的问题单独沟通 。

@YanjieGao
Copy link
Contributor Author

YanjieGao commented Apr 23, 2022

Dear Author, 请同时阅读其他章节内容, 我们需要章节间内容的一些叙事铺垫, 内容呼应和内容去重,当前图书不太适合完全孤立的书写各章,请大家和各章节作者再就这些如果发现的问题单独沟通 。

尤其第一章会recall各个章节,请大家Double check内容是否需要调整。
参考:
https://github.com/microsoft/AI-System/blob/main/Textbook/%E7%AC%AC1%E7%AB%A0-%E4%BA%BA%E5%B7%A5%E6%99%BA%E8%83%BD%E7%B3%BB%E7%BB%9F%E6%A6%82%E8%BF%B0/1.4-%E6%B7%B1%E5%BA%A6%E5%AD%A6%E4%B9%A0%E6%A0%B7%E4%BE%8B%E8%83%8C%E5%90%8E%E7%9A%84%E7%B3%BB%E7%BB%9F%E9%97%AE%E9%A2%98.md

@YanjieGao
Copy link
Contributor Author

请调整格式哈

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants