Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on the tutorial #4

Open
Kagigz opened this issue Nov 5, 2018 · 0 comments
Open

Feedback on the tutorial #4

Kagigz opened this issue Nov 5, 2018 · 0 comments

Comments

@Kagigz
Copy link
Contributor

Kagigz commented Nov 5, 2018

Hi,

I have several comments regarding this tutorial:

There's no local.settings.json file.

In the "Create the orchestrator Azure Function/Configure the app to use Custom Vision" section, it says "open the local.settings.json in the root of the Sketch2Code.Api project" but it is in the git ignore so there's no file.

I was able to test the function by using Azure CLI and calling the
func azure functionapp fetch-app-settings <name>
command to create the file, then adding the properties mentioned in the tutorial.

I think the local.settings.json file should be added in the project.

There is no indication on how to test with Powershell.

I replaced the command curl with curl.exe to make it work.

I think it's worth mentioning in the tutorial.

App Function endpoint is not clear.

In the "Run the Sketch2Code app/Update App Settings" section, it says "Make sure that the Sketch2CodeAppFunctionEndPoint property has the correct function endpoint URL that you use before to call the function", which in my opinion isn't very clear.

Personally, I couldn't make the web app work - I tried with 2 endpoints, including the "http://localhost:7071/api/detection" one (with the Azure Function up and running), but when I try uploading a picture I get a message "Host lock lease acquired by instance ID XXXX..." and there's no result.

Hope this feedback will help improve the tutorial which is otherwise really great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant