Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyvaultsecrets with umlauts are passed incorrectly and unmasked #131

Closed
juliandittmann opened this issue May 18, 2022 · 4 comments
Closed
Labels
bug Something isn't working Fix Ready Fix Ready

Comments

@juliandittmann
Copy link

Steps to reproduce:

  • Create a secret with umlauts (ö,ä,ü, ... )
  • Run CI/CD workflow

Note: I used a keyvault.

The secrets are recieved correctly from the vault but somehow are passed incorrectly.
This results in unmasking secrets and futher errors.

Example:
image

@freddydk freddydk added the bug Something isn't working label May 26, 2022
@freddydk
Copy link
Collaborator

I have spent a lot of time trying to figure out a way to make this work - and I will have to give up.
I do see this as a bug in GitHub, which I assume they will fix at some point in time.
At the same time, it is crucial that secrets are not revealed by the system, so from the next version of AL-Go - you will get this error if a secret contains characters, which are outside the range of 32..126
image

One workaround would be to implement support for some secrets could be base64 encoded (like provide :::: as your secret value and I will decode when used). This would be quite a lot of work, and might not be needed. I will assess based on feedback.

@freddydk
Copy link
Collaborator

I will mark the bug as fixed, as it will no longer reveal your secrets, knowing that you will have to change your URL to NOT contain special characters.

@freddydk
Copy link
Collaborator

Released in preview

@freddydk
Copy link
Collaborator

Shipped in v1.5

freddydk added a commit that referenced this issue Dec 22, 2022
'Collect changes from freddydk/*@main'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fix Ready Fix Ready
Projects
None yet
Development

No branches or pull requests

2 participants