Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Message for "Increment Version Number" workflow #143

Closed
achim-t opened this issue May 31, 2022 · 3 comments
Closed

Commit Message for "Increment Version Number" workflow #143

achim-t opened this issue May 31, 2022 · 3 comments
Labels
bug Something isn't working Fix Ready Fix Ready

Comments

@achim-t
Copy link

achim-t commented May 31, 2022

I used +0.1 to only increment the minor version.

commit

The commit message reads 'New Version number 0.1' when it should read 'New Version number 1.1'.

('New Version number +0.1' might be acceptable as well.)

Also, the .json files is are formatted differently from the VS Code formatter. It looks like the change is much bigger than it actually is.

@freddydk
Copy link
Collaborator

Will fix the commit message bug

The .json files are formatted using the PowerShell ConvertTo-Json - I don't think I can influence that, meaning that the first time you do this, it will look like this. Not sure I can do much about that.
In the Pull Request you can click: Ignore WhiteSpace changes.

VS Code doesn't format unless you ask specifically about it.

@freddydk
Copy link
Collaborator

freddydk commented Jun 1, 2022

The message will be

Increment Version number by 0.1

if you used the incremental step and

New Version number 1.1

if you use the absolute

@freddydk
Copy link
Collaborator

Shipped in v2.0

freddydk added a commit that referenced this issue Jan 9, 2023
'Collect changes from freddydk/*@issue324'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fix Ready Fix Ready
Projects
None yet
Development

No branches or pull requests

2 participants