Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastlane, Pilot - Automatic Team Selection #34

Closed
aldodfm opened this issue Sep 20, 2016 · 3 comments
Closed

Fastlane, Pilot - Automatic Team Selection #34

aldodfm opened this issue Sep 20, 2016 · 3 comments

Comments

@aldodfm
Copy link
Contributor

aldodfm commented Sep 20, 2016

Hello,

In Release task you are requesting or giving the option to infor teamID and teamName, but is not used in any place in the Task's code.

var teamId: string = tl.getInput("teamId", false);
var teamName: string = tl.getInput("teamName", false);
            // Run pilot to upload to testflight
            var pilotCommand: ToolRunner = tl.tool('pilot');
            pilotCommand.arg(['upload', '-u', credentials.username, '-i', ipaPath]);
            if(isValidFilePath(releaseNotes)) {
                pilotCommand.arg(['--changelog', fs.readFileSync(releaseNotes).toString()]);
            }
            pilotCommand.argIf(shouldSkipSubmission, ['--skip_submission', 'true']);
            pilotCommand.argIf(shouldSkipWaitingForProcessing, ['--skip_waiting_for_build_processing', 'true']);
            await pilotCommand.exec();

So, you need to add the parameters like in promote task:

        //Run the deliver command 
        // See https://github.com/fastlane/deliver for more information on these arguments
        var deliverCommand : ToolRunner = tl.tool('deliver');
        deliverCommand.arg(['submit_build', '-u', credentials.username, '-a', appIdentifier]);
        if (chooseBuild.toLowerCase() === 'specify') {
           deliverCommand.arg(['-n', buildNumber]);     
        }
        deliverCommand.arg(['--skip_binary_upload', 'true', '--skip_metadata', 'true', '--skip_screenshots', 'true']);
        deliverCommand.argIf(shouldAutoRelease, '--automatic_release');
        deliverCommand.argIf(teamId, ['-b', teamId]);
        deliverCommand.argIf(teamName, ['-l', teamName]);
        deliverCommand.arg('--force');
@aldodfm
Copy link
Contributor Author

aldodfm commented Sep 21, 2016

Hello,

I created a PR with this Fix. #35

@itunyk
Copy link

itunyk commented Oct 21, 2016

Hello, when it's going to be in production?

@madhurig madhurig added the bug label Dec 8, 2016
@madhurig
Copy link
Contributor

madhurig commented Dec 9, 2016

@madhurig madhurig closed this as completed Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants