-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the API more Swifty #1627
Comments
@sindresorhus thanks for the suggestion. We are always open to the ways to improve the SDK. |
@sindresorhus I appreciate your suggestion for Swift methods of App Center SDK. Unfortunately, it is not in our immediate plan to support it. We will keep this thread open for developers to comment and vote, and keep you posted once we decide to work on it. |
@jaeklim none of @sindresorhus has suggested requires you to use Swift directly. This can all be done by properly structuring your Objective-C API using properties (both instance and class properties). I'll draw up a PR with at least what @sindresorhus has suggested above as an exemplar. |
@tonyarnold sure, feel free to create PR. |
Thanks for bumping up the topic and submitting a PR @tonyarnold . This is indeed some good improvements we can take, we are welcoming contributions. We’ll review the PR. FYI among other thing we are looking at to approve a PR is the consistency between modules particularly because this topic impacts all modules. If any breaking change is to be added it should be added in a separate PR because it’ll probably stack up until the next SDK major version will show up. If we think we need to iterate on this we can create feature branches. |
The feature has been released in 4.0.0 version of App Center. |
Please pass on my thanks to your team, @AnastasiaKubova 😁 |
Really nice work on this everyone. I did notice one thing though. It went from |
Hi @sindresorhus! |
The whole point was to swiftify the API, meaning less consistency between Swift and Objective-C. Why not do it 100%? |
@sindresorhus, we considered and discussed it thoroughly within the team while doing these changes, and it was decided to use I'm sorry to inform you that, but we are not planning to do any updates related to Swift-friendly API. |
The API could be more user-friendly for Swift users.
Some quick examples of what I would recommend:
More here: https://developer.apple.com/documentation/swift/objective-c_and_c_code_customization/improving_objective-c_api_declarations_for_swift
The text was updated successfully, but these errors were encountered: