Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Center pods are not updated when updating npm package (aka RNMobileCenterShared not found) #59

Closed
brianinator opened this issue Jul 26, 2017 · 5 comments
Labels
Milestone

Comments

@brianinator
Copy link

screen shot 2017-07-26 at 7 32 09 pm

I see this in RNCrashes, RNAnalytics and RNMobileCenter. I have mobile-center@0.7.0 installed. And the following in Podfile:

  # Pods for Mobile Center
  pod 'RNMobileCenterShared', '~> 0.6.0'
  pod 'MobileCenter', '~> 0.10'
@guperrot
Copy link
Member

Hi, seems like you updated the NPM package from version 0.6.0 to 0.7.0?

It seems the Podfile is not updated by react-native link command in that case, you need to update the 2 versions manually in the Podfile unfortunately.

Replace 0.6.0 by 0.7.0 for RNMobileCenterShared and replace 0.10 by 0.10.1 for MobileCenter line.

Then run pod update inside the ios folder.

We need to make the update experience better, thanks for the report.

@guperrot guperrot added the bug label Jul 27, 2017
@brianinator
Copy link
Author

brianinator commented Jul 27, 2017

I want to add pod update might be dangerous if the project includes other pods. I think a better approach might be to update the versions to pods in the Podfile and do a pod install.

I'm happy to report that updating the RNMobileCenterShared and MobileCenter pods addresses this issue. Thanks.

@guperrot
Copy link
Member

Hi, that's a good point, when fixing the linker script we will be careful about updating only Mobile Center pods and not anything else.

Let me rename ticket and leave it opened to automate the process.

@guperrot guperrot changed the title Module RNMobileCenterShared missing Mobile Center pods are not updated when updating npm package Jul 27, 2017
@guperrot guperrot reopened this Jul 27, 2017
@guperrot guperrot changed the title Mobile Center pods are not updated when updating npm package Mobile Center pods are not updated when updating npm package (aka RNMobileCenterShared not found) Jul 27, 2017
@guperrot
Copy link
Member

guperrot commented Aug 1, 2017

#63 will fix this

@guperrot guperrot added this to the 0.8.0 milestone Aug 2, 2017
@guperrot
Copy link
Member

guperrot commented Aug 4, 2017

Fix released.

@guperrot guperrot closed this as completed Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants