internal SDK version is not set

[southwood]

We should be emitting this to the context tags:
https://github.com/Microsoft/AppInsights-Android/blob/feature/channel-refactoring/applicationinsights-android/src/main/java/com/microsoft/applicationinsights/internal/TelemetryContext.java#L345-L353

currently it's not set in the payload:

[{
    "ver": 1,
    "name": "Microsoft.ApplicationInsights.Crash",
    "time": "2015-04-11T00:22:40.291Z",
    "sampleRate": 100.0,
    "iKey": "1743b6cf-8366-4a85-91c9-8ddfdeaefc3e",
    "deviceId": "CD4AB54D1385C789980EFA8C2F881F7EFF1049BF1DBD6F3628541CC3475175B0",
    "os": "Android",
    "osVer": "5.0",
    "appId": "com.microsoft.applicationinsights.sampleapp",
    "appVer": "com.microsoft.applicationinsights.sampleapp (1)",
    "userId": "7991fd27-8257-48f9-8dd6-07a3d47d3cb6",
    "tags": {
        "ai.device.id": "CD4AB54D1385C789980EFA8C2F881F7EFF1049BF1DBD6F3628541CC3475175B0",
        "ai.device.locale": "en_US",
        "ai.device.model": "[Emulator]Android SDK built for x86",
        "ai.device.network": "Mobile",
        "ai.device.oemName": "unknown",
        "ai.device.os": "Android",
        "ai.device.osVersion": "5.0",
        "ai.device.type": "Phone",
        "ai.session.id": "eda04a63-5be7-4a95-8f09-a5a403de1fae",
        "ai.user.accountAcquisitionDate": "2015-04-10T21:42:30.380Z",
        "ai.user.id": "7991fd27-8257-48f9-8dd6-07a3d47d3cb6"
    },
    "data": {
        "baseType": "Microsoft.ApplicationInsights.CrashData",
        "baseData": {
            "ver": 2,
            "headers": {
                "id": "56303f84-91c5-4e54-bba7-4d25016350fd",
                "applicationPath": "com.microsoft.applicationinsights.sampleapp",
                "exceptionType": "java.lang.RuntimeException",
                "exceptionReason": "oh no!"
            },
            "threads": [{
                "id": 0,
                "frames": [{
                    "address": "",
                    "symbol": "com.android.internal.os.ZygoteInit.main(ZygoteInit.java:694)"
                }, {
                    "address": "",
                    "symbol": "com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:899)"
                }, {
                    "address": "",
                    "symbol": "java.lang.reflect.Method.invoke(Method.java:372)"
                }, {
                    "address": "",
                    "symbol": "java.lang.reflect.Method.invoke(Native Method)"
                }, {
                    "address": "",
                    "symbol": "android.app.ActivityThread.main(ActivityThread.java:5221)"
                }, {
                    "address": "",
                    "symbol": "android.os.Looper.loop(Looper.java:135)"
                }, {
                    "address": "",
                    "symbol": "android.os.Handler.dispatchMessage(Handler.java:95)"
                }, {
                    "address": "",
                    "symbol": "android.os.Handler.handleCallback(Handler.java:739)"
                }, {
                    "address": "",
                    "symbol": "android.widget.AbsListView$3.run(AbsListView.java:3833)"
                }, {
                    "address": "",
                    "symbol": "android.widget.AbsListView$PerformClick.run(AbsListView.java:3044)"
                }, {
                    "address": "",
                    "symbol": "android.widget.AbsListView.performItemClick(AbsListView.java:1143)"
                }, {
                    "address": "",
                    "symbol": "android.widget.AdapterView.performItemClick(AdapterView.java:300)"
                }, {
                    "address": "",
                    "symbol": "android.support.v4.app.ListFragment$2.onItemClick(ListFragment.java:58)"
                }, {
                    "address": "",
                    "symbol": "com.microsoft.applicationinsights.appsample.ItemListFragment.onListItemClick(ItemListFragment.java:138)"
                }, {
                    "address": "",
                    "symbol": "com.microsoft.applicationinsights.appsample.ItemListFragment.crashMe1(ItemListFragment.java:158)"
                }, {
                    "address": "",
                    "symbol": "com.microsoft.applicationinsights.appsample.ItemListFragment.crashMe2(ItemListFragment.java:162)"
                }, {
                    "address": "",
                    "symbol": "com.microsoft.applicationinsights.appsample.ItemListFragment.crashMe3(ItemListFragment.java:166)"
                }]
            }]
        }
    }
}]

[ghost]

As a quick side note: I think Android should be lowercase to be consistent with the other SDKs :)

[ElektrojungeAtWork]

Fixed in de12c17

[ElektrojungeAtWork]

Changed to "android" as suggested by @lukasspiess in 616943d

[ghost]

:)