Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

TraceListener adds EventId property that is always 0 #4

Closed
abaranch opened this issue Nov 30, 2015 · 1 comment
Closed

TraceListener adds EventId property that is always 0 #4

abaranch opened this issue Nov 30, 2015 · 1 comment
Assignees
@abaranch
Labels
bug p3
Milestone
93

Comments

@abaranch
Copy link
Contributor

When 'public override void Write(string message)' override is used EventId property is added with value 0. We should not add this property for this override. For other overrides 0 is a legitimate value. (Consider making EventId nullable and ckeck for null)
@AlexBulankou AlexBulankou added this to the 93 milestone Dec 3, 2015
@AlexBulankou AlexBulankou added the p3 label Dec 3, 2015
@abaranch abaranch mentioned this issue Dec 8, 2015
Merged
@abaranch abaranch self-assigned this Dec 8, 2015
@abaranch abaranch closed this as completed Dec 8, 2015
@abaranch
Copy link
Contributor Author

Write and WriteLine overrides are fixed.
TraceInformation, TraceWarning etc will add event id as 0 and we cannot fix it (internally it calls to TraceEvent providing 0 as event id).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abaranch abaranch

Labels
bug p3
Projects
None yet
Milestone
93
Development

No branches or pull requests
2 participants
@abaranch @AlexBulankou